[tests-only][full-ci] Refactor group store for e2e tests #8914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
refactor-group-store
branch
from
c93cbb4 to
ab1f7c0
Compare
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/35451/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35451/tracing/assign-user-to-groups-admin-2023-5-5-08-30-04.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35451/tracing/user-group-assignments-can-be-handled-via-batch-actions-admin-2023-5-5-08-28-52.zip |
amrita-shrestha
force-pushed
the
refactor-group-store
branch
from
ab1f7c0 to
da1fb18
Compare
amrita-shrestha
requested review from
SwikritiT,
saw-jan,
grgprarup,
SagarGi and
PrajwolAmatya
|
Kudos, SonarCloud Quality Gate passed!
|
SwikritiT
approved these changes
May 8, 2023
ScharfViktor
approved these changes
May 8, 2023
saw-jan
pushed a commit
that referenced
this pull request
May 11, 2023
* Refactor group store * Minor changes
9 tasks
saw-jan
pushed a commit
that referenced
this pull request
May 11, 2023
* Refactor group store * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes dummyGroup uses other than getting group dummy value at creation time.
Now created group will be stored in createdGroup. Currently, createdGroupStore is cleared at
Afterhook because we need group id to check whether the group exists after the deletion or norRelated Issue
Follow-up PR of
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: