Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor user/group/link/spaces stores for e2e tests #8819

Closed
individual-it opened this issue Apr 17, 2023 · 1 comment
Closed

refactor user/group/link/spaces stores for e2e tests #8819

individual-it opened this issue Apr 17, 2023 · 1 comment
Assignees

Comments

@individual-it
Copy link
Member

We have two different types of "stores" in the e2e tests:

  1. dummy-data-store: They are used to keep data for dummies (users & groups). Only users/users that are in that store can be created by the tests. While creating a user/group, the data from the store is used to add to the users-details given by the tests. E.g. the test does not need to mention the display name of a user, it is drawn from the user-store.
  2. created-items-store: They are used to remember which items are created during a test run and then to check the results in later step or to delete those items in the afterScenario, see [e2e]Cleanup users/groups/spaces created by test scenario after execution of tests #8662. We cannot use the dummy-data-stores for the cleanup task, because not all items in that store have been actually created.

In the current code both type of stores are called the same. userStore and groupStore are "dummy-data-stores", linkStore, spacesStore, etc. are created-items-store. (userRoleStore is again used a bit different)
I find naming those things similar very confusing and so I suggest to separate those concepts.

  1. name the stores that are used for creating items something like dummyUserStore
  2. name the stores that are used to remember created item something like createdUserStore

CC @ScharfViktor @fschade
I think that way it would be much easier to understand what is needed for what and will make the PRs for #8662 much cleaner.

@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented May 8, 2023

refactoring has been done for the group and user store. No need to refactor space and link store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants