Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Restructure stores for e2e tests #8848

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[tests-only][full-ci] Restructure stores for e2e tests #8848

merged 1 commit into from
Apr 18, 2023

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Apr 18, 2023 •
edited
Loading

Description

This PR restructure stores for e2e tests
We have two ways to structure the store

  1. adding created and dummy in a different folder (1dec327)
    Screenshot from 2023-04-18 16-19-04
  2. next is to create different variables that store dummy and created-item separately in the same file. This method is implemented in this PR (https://github.com/owncloud/web/pull/8848/files)
    Screenshot from 2023-04-18 16-23-37

In follow-up PR, user/group creation, deletion, and an update will be linked to createdSpaceStore, createdLinkStore

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@amrita-shrestha amrita-shrestha force-pushed the resturcture-e2e-store-folder branch from 1dec327 to 067e63d Compare April 18, 2023 09:40
@amrita-shrestha amrita-shrestha force-pushed the resturcture-e2e-store-folder branch from 067e63d to 1339d86 Compare April 18, 2023 09:42
@amrita-shrestha amrita-shrestha requested a review from saw-jan April 18, 2023 09:46
@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 18, 2023 09:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit 7d77642 into master Apr 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the resturcture-e2e-store-folder branch April 18, 2023 11:52
This was referenced Apr 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@saw-jan saw-jan saw-jan approved these changes

@individual-it individual-it individual-it approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees
No one assigned
Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrita-shrestha @individual-it @saw-jan @ScharfViktor