Add support for read-only groups #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
readonly-groups
branch
from
c151d70 to
adf6e58
Compare
JammingBen
force-pushed
the
readonly-groups
branch
from
adf6e58 to
4a955ee
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Apr 5, 2023
| ...g, | ||
| readonly: g.groupTypes?.includes('ReadOnly') | ||
| })) | ||
| .sort((a: any, b: any) => b.readonly - a.readonly) |
There was a problem hiding this comment.
I know, I know 😄 But even when using the correct types here, TS would complain that you can't subtract boolean values from another.
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for read-only groups. Such groups can't be edited or assigned to/removed from users. They are indicated via a lock icon in the group list and all affected inputs.
Needs latest oCIS master! You can test it by following the instructions given in owncloud/ocis#5974.
Related Issue
Screenshots:
Types of changes
To-Do's:
groupTypesproperty? -> is available after Implement GDPR export for users #8741 has been merged