Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GDPR export for users #8741

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Implement GDPR export for users #8741

merged 2 commits into from
Apr 4, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Mar 29, 2023 •
edited
Loading

Description

Adds a GDPR export on the account page of each user. Note that this is only supported when running oCIS as backend.

The post-processing state can be tested when starting the server with:

POSTPROCESSING_DELAY: "30s"
STORAGE_USERS_OCIS_ASYNC_UPLOADS: "true"

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Mar 29, 2023
@JammingBen JammingBen force-pushed the gdpr-export branch 3 times, most recently from c86edab to 3c4d780 Compare March 31, 2023 09:35
JammingBen
JammingBen commented Mar 31, 2023
View reviewed changes
packages/web-client/src/graph.ts
Comment on lines -136 to -137
0,
0,
Copy link
Contributor Author

@JammingBen JammingBen Mar 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but some parameters seem to have gone after updating the graph client.

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

82.0% 82.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review April 3, 2023 06:08
@JammingBen
Copy link
Contributor Author

JammingBen commented Apr 3, 2023 •
edited
Loading

This is ready for review, although the server does not ship the capability yet. So for testing, you need to set it to true manually: https://github.com/owncloud/web/pull/8741/files#diff-f2ac05790ff955307ad01dea9de39462b2f5f017959394934eaad70208f0b1a7R143 -> now works with the latest oCIS docker image.

@JammingBen JammingBen requested review from dschmidt and kulmann April 3, 2023 06:09
@JammingBen JammingBen mentioned this pull request Apr 3, 2023
Merged
10 tasks
dschmidt
dschmidt approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm and the code LGTM. :shipit:

@JammingBen JammingBen merged commit 13f2abe into master Apr 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the gdpr-export branch April 4, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Trigger GDPR Export
2 participants
@JammingBen @dschmidt