[full-ci] Rename groups + refactoring #8715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
TBD:
|
AlexAndBear
force-pushed
the
group-rename
branch
3 times, most recently
from
84e4a0d to
09346d6
Compare
AlexAndBear
commented
Mar 30, 2023
| }) | ||
| expect(wrapper.vm.isFormInvalid).toBeFalsy() |
There was a problem hiding this comment.
Faked to make tests run trougj!
AlexAndBear
commented
Mar 30, 2023
Comment on lines
53
to
54
| When "Admin" changes displayName to "it sales department" for group "sales" using the sidebar panel | ||
| And "Admin" logs out |
There was a problem hiding this comment.
There is a confirmation step missing which doesn't exist on other tests as well.
|
So there are still 2 tests that are failing still trying out to get behind it. Other than that with skipped tests the whole ci went trough. |
AlexAndBear
commented
Mar 30, 2023
| @@ -39,3 +39,17 @@ Feature: groups management | |||
| | security | | |||
| | finance | | |||
| And "Admin" logs out | |||
|
|
|||
| Scenario: edit groups | |||
JammingBen
reviewed
Mar 31, 2023
packages/web-app-admin-settings/src/components/Groups/SideBar/GroupInfoBox.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/composables/actions/groups/useGroupActionsEdit.ts
Outdated
Show resolved
Hide resolved
10 tasks
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/34475/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34475/tracing/participant-management-alice-2023-4-3-10-47-33.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34475/tracing/re-sharing-brian-2023-4-3-10-43-21.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34475/tracing/user-should-be-able-to-read-and-dismiss-notifications-alice-2023-4-3-10-43-06.zip |
JammingBen
changed the title
…/useGroupActionsEdit.ts Co-authored-by: Jannik Stehle <[email protected]>
…GroupInfoBox.vue Co-authored-by: Jannik Stehle <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Apr 3, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: