[full-ci] Create space from resource #8730
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Base implementation is done, TBD:
|
|
Only seems to work as admin, with other users the option in the context menu is missing |
expected, because you need the permission to create spaces. otherwise the feature doesn't make sense. |
|
yes right, sorry didn't notice other users didn't have the permission |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/34490/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34490/tracing/share-a-link-with-internal-role-alice-2023-4-4-09-02-55.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34490/tracing/share-a-link-with-internal-role-brian-2023-4-4-09-03-06.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34490/tracing/tag-search-alice-2023-4-4-09-13-01.zip |
lookacat
changed the title
JammingBen
force-pushed
the
create-space-from-resource
branch
from
2208f13 to
e7c6b0e
Compare
| store.dispatch('showMessage', { | ||
| title: $gettext('Creating space failed…'), | ||
| status: 'danger' | ||
| }) |
There was a problem hiding this comment.
Hm, what if the space was created partially?
Like 3 out of 5 files were copied: do we want to keep the broken space or would it potentially make sense to delete it?
I would really like to avoid that users somehow miss the error message, see the space was created and then delete the source files because they think their data is in the space now.
@tbsbdr what do you think?
There was a problem hiding this comment.
I created #8775 to follow up on this (very valid!) point. However, IMO that's not a merge blocker for now as we're heading towards the finish line for this sprint.
|
SonarCloud Quality Gate failed. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: