Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Fix flaky 'create-space-from-resource'-e2e test #8781

Merged
merged 3 commits into from
Apr 12, 2023
Merged

[tests-only] Fix flaky 'create-space-from-resource'-e2e test #8781

merged 3 commits into from
Apr 12, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Apr 5, 2023 •
edited
Loading

Description

Fixes flaky e2e tests that were introduced with #8730.

I'd prefer to wait for requests here, but there can be n requests, and we don't know n inside the test step.

Potentially fixes the broken pipeline in https://drone.owncloud.com/owncloud/ocis/21162/68/10.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Apr 5, 2023
@JammingBen JammingBen force-pushed the fix-flaky-create-space-from-resource-e2e branch from 25562ce to 494df02 Compare April 5, 2023 15:08
@JammingBen JammingBen requested a review from ScharfViktor April 5, 2023 15:48
@JammingBen JammingBen requested a review from ScharfViktor April 5, 2023 16:23
@JammingBen JammingBen mentioned this pull request Apr 5, 2023
Merged
@JammingBen JammingBen marked this pull request as draft April 5, 2023 16:31
@JammingBen
Copy link
Contributor Author

JammingBen commented Apr 5, 2023 •
edited
Loading

Converting this to a draft because we temporarily skip the tests to get the pipeline green for the deployment: #8783. We can merge this afterwards to check, if it solves the issue. Back to normal :D After we merged this I'll check if it fixes the oICS pipeline.

@JammingBen JammingBen marked this pull request as ready for review April 5, 2023 19:06
@JammingBen JammingBen force-pushed the fix-flaky-create-space-from-resource-e2e branch from 1dce5a2 to 4a1da15 Compare April 12, 2023 06:47
@JammingBen JammingBen force-pushed the fix-flaky-create-space-from-resource-e2e branch from 4a1da15 to dbccf35 Compare April 12, 2023 06:49
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit d824195 into master Apr 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-flaky-create-space-from-resource-e2e branch April 12, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @kulmann @ScharfViktor