Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle failure when creating a space from resources #8775

Open
JammingBen opened this issue Apr 5, 2023 · 1 comment
Open

Properly handle failure when creating a space from resources #8775

JammingBen opened this issue Apr 5, 2023 · 1 comment

Comments

@JammingBen
Copy link
Contributor

This is a follow-up for #8730.

What should happen when something fails during the copy-process of resources to a new space? Should we revert the whole process (= delete the newly created space again)? Or should we keep the space despite its missing items?

Either way, we need to adjust the error message in such case. Currently it would state Creating space failed….

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Apr 5, 2023

@tbsbdr could you please make a decision. I am fine with deleting the space as "the mission failed".
I don't expect the user comparing the space content and copy the missing files by hand.

If so, could you also provide a dedicated message string ? 🖤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants