[full-ci] Add remove/add users to group batch actions #8553
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/33455/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33455/tracing/folder-alice-2023-3-8-12-16-47.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33455/tracing/folder-brian-2023-3-8-12-17-02.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33455/tracing/user-login-can-be-managed-in-the-admin-settings-admin-2023-3-8-12-12-59.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33455/tracing/user-login-can-be-managed-in-the-admin-settings-admin-2023-3-8-12-13-04.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33455/tracing/user-login-can-be-managed-in-the-admin-settings-alice-2023-3-8-12-13-03.zip |
JammingBen
force-pushed
the
add-remove-users-groups-batch
branch
from
852f2fb to
9f0b226
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/33450/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33450/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-3-8-11-46-11.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33450/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-3-8-11-46-43.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33450/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-3-8-11-46-48.zip |
JammingBen
changed the title
JammingBen
force-pushed
the
add-remove-users-groups-batch
branch
from
4fce834 to
135191a
Compare
There was a problem hiding this comment.
Feature works as expected. Thanks for the detour with batch actions in the AppTemplate and for already using the composable syntax for the actions! ❤️
Added some comments about things that need to be fixed before merge. Please don't merge before those are done as well. :-) Approving because I'm OOTO tomorrow and on friday and don't want to block this (and it's only complaints about visual defects)
packages/web-app-admin-settings/src/components/Users/GroupsModal.vue
Outdated
Show resolved
Hide resolved
|
Converted to draft so that this doesn't get merged accidentally. |
|
THX! |
JammingBen
force-pushed
the
add-remove-users-groups-batch
branch
from
c7e72a0 to
294e169
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Added a ocis ticket to minimize request owncloud/ocis#5783 |
Description
Adds new batch actions for adding and removing group assignments to the users list in the admin settings.
Related Issue
Screenshots:
Types of changes