Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selection model to tiles view #8392

Merged
merged 9 commits into from
Feb 9, 2023
Merged

Add selection model to tiles view #8392

merged 9 commits into from
Feb 9, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 8, 2023 •
edited
Loading

Related Issue

Screenshots

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Follow-up:

  • Improve multi-selection in "Spaces" view

@JammingBen JammingBen self-assigned this Feb 8, 2023
@JammingBen JammingBen force-pushed the tiles-view-selection branch from 963b8b1 to e0c7fd7 Compare February 8, 2023 09:13
@owncloud owncloud deleted a comment from update-docs bot Feb 8, 2023
@JammingBen JammingBen marked this pull request as ready for review February 8, 2023 10:16
dschmidt
dschmidt reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard for me to judge the template/style changes, but code wise it's looking good!

packages/web-app-files/src/components/FilesList/ResourceTiles.vue Show resolved Hide resolved
dschmidt
dschmidt reviewed Feb 8, 2023
View reviewed changes
sonar-project.properties
@@ -32,4 +32,4 @@ sonar.pullrequest.key=${env.SONAR_PULL_REQUEST_KEY}
sonar.javascript.lcov.reportPaths=coverage/lcov.info

# Exclude files
sonar.exclusions=docs/**,node_modules/**,deployments/**,**/tests/**,__mocks__/**,__fixtures__/**,dist/**,changelog/**,config/**,docker/**,release/**,**/package.json,package.json,rollup.config.js,nightwatch.conf.js,Makefile,Makefile.release,CHANGELOG.md,README.md,packages/web-client/src/generated/**,packages/web-integration-oc10/**
sonar.exclusions=docs/**,node_modules/**,deployments/**,**/tests/**,**/*.spec.ts,__mocks__/**,__fixtures__/**,dist/**,changelog/**,config/**,docker/**,release/**,**/package.json,package.json,rollup.config.js,nightwatch.conf.js,Makefile,Makefile.release,CHANGELOG.md,README.md,packages/web-client/src/generated/**,packages/web-integration-oc10/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@pascalwengerter
Copy link
Contributor

@JammingBen needs a quick rebase since #8372 got merged 😇 shouldn't be painful though

@JammingBen JammingBen force-pushed the tiles-view-selection branch from 759548b to 48f4d60 Compare February 9, 2023 08:44
@JammingBen JammingBen requested a review from kulmann February 9, 2023 08:46
@ownclouders
Copy link
Contributor

ownclouders commented Feb 9, 2023 •
edited
Loading

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32611/23/1
💥 The oC10SharingAccept tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/32610/69/1
💥 The oCISSharingPublic2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32610/75/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32610/73/1
💥 The oC10IntegrationNotifications tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/32610/70/1
💥 The oCISSharingPublic3 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/32610/71/1
💥 The oCISUploadMove tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/32610/72/1
💥 The oCISTrashbinJourney tests pipeline failed. The build has been cancelled.

kulmann
kulmann requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving this! UX and design is gorgeous!

Two things:

  1. see comment, hardcoded font sizes are a no-no 😅
  2. see screenshot, why are the file type icons so tiny on big tile sizes? that's not the case on master (note: I made the screenshot when I had previews disabled. also had a test run with previews enabled 😉 )

Screenshot 2023-02-09 at 11 29 23

packages/web-app-files/src/components/FilesList/ResourceTiles.vue Outdated Show resolved Hide resolved
@JammingBen
Copy link
Contributor Author

@kulmann

see screenshot, why are the file type icons so tiny on big tile sizes? that's not the case on master (note: I made the screenshot when I had previews disabled. also had a test run with previews enabled 😉 )

The file type icon size is currently independent of the tile size. I made them smaller in general, because they were too big when using the small tiles. It would make sense to scale them with the tile size, but I'd rather do that in a separate PR.

@JammingBen JammingBen force-pushed the tiles-view-selection branch from 880ca16 to 3d50dab Compare February 9, 2023 10:46
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

51.9% 51.9% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@JammingBen JammingBen merged commit 9a64098 into master Feb 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the tiles-view-selection branch February 9, 2023 11:15
ownclouders pushed a commit that referenced this pull request Feb 9, 2023
@JammingBen
commit 9a64098
fba1a08 
Author: Jannik Stehle <[email protected]>
Date:   Thu Feb 9 12:15:12 2023 +0100

    Add selection model to tiles view (#8392)

    * Add selection model to tiles view

    * Add outline to selected tiles

    * Add unit tests, fix snapshots

    * Fix checkbox label translation

    * Exclude spec-files from SonarCloud coverage

    * Rename setSelection to toggleSelection

    * Fix initial tile size loading

    * Improve tile size slider background in dark mode

    * Use oc-font-size-default instead of rem
@JammingBen JammingBen mentioned this pull request Feb 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt left review comments

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tiles view] Add selection model
5 participants
@JammingBen @pascalwengerter @ownclouders @dschmidt @kulmann