Fix ResourceTiles on mobile and add basic resize slider for tiles #8372
Conversation
| @@ -31,4 +31,6 @@ export abstract class ViewModeConstants { | |||
| } | |||
| } | |||
| static readonly queryName: string = 'view-mode' | |||
| static readonly tilesSizeDefault: string = '12rem' | |||
There was a problem hiding this comment.
| static readonly tilesSizeDefault: string = '12rem' | |
| static readonly tilesSizeDefault: number = 1 |
| @@ -22,3 +22,8 @@ size: | |||
| value: 22px | |||
| form-check-default: | |||
| value: 14px | |||
| tiles: | |||
| resizeable: | |||
There was a problem hiding this comment.
| resizeable: | |
| resize-step: |
or something similar? resizable (typo btw) sounds like a boolean.
There was a problem hiding this comment.
Great idea, and thanks for the educate - turns out past me already made this mistake :D #5052
pascalwengerter
force-pushed
the
features/8367-8368
branch
from
ce2d5c9 to
385dada
Compare
| tiles: | ||
| resize-step: | ||
| value: 12rem | ||
| default: |
There was a problem hiding this comment.
The default is not in use. Delete it?
There was a problem hiding this comment.
Good point, thx. It's meant to be used for non-resizable tiles (like the ones on the spaces-projects view), I added the token without actually using it in the component 🙈 see latest commit in this PR
| @@ -22,3 +22,8 @@ size: | |||
| value: 22px | |||
| form-check-default: | |||
| value: 14px | |||
| tiles: | |||
| resize-step: | |||
There was a problem hiding this comment.
If resize-step is the only size value for tiles, we could omit the nesting and just have something like
tiles-step:
value: 12rem
pascalwengerter
force-pushed
the
features/8367-8368
branch
from
fb42ba4 to
668b397
Compare
pascalwengerter
force-pushed
the
features/8367-8368
branch
from
45b3e28 to
984624e
Compare
|
SonarCloud Quality Gate failed. |
…ynamic index problem)
Description
Didn't invest the time to create a
OcSlidercomponent but kept it inline, also doesn't fetch bigger tiles thumbnails since the current resolution seems quite reasonable even on bigger tiles.Related Issue