Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-select in spaces view #8404

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 9, 2023

Description

  • Fix broken sidebar state when selecting multiple spaces
  • Add "Clear selection" action when multiple spaces are selected

Related Issue

Screenshots

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Feb 9, 2023
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32622/38/1
💥 The oC10SharingPublic2 tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

54.2% 54.2% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 4bafe0d into master Feb 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the spaces-view-multi-selection branch February 9, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants