-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Vue 3: Disable compat mode #8288
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
2d21bc2
to
aaa4f56
Compare
bc4599a
to
40824fa
Compare
b0f8532
to
24d5dbd
Compare
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/31999/67/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L47.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L48.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L49.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L50.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L51.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L52.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L54.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L55.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L56.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L57.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L58.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L59.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L54.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L55.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L56.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L57.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L58.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L59.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L60.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L61.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L62.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L63.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L64.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L65.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.png |
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/31999/36/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L54.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L55.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L56.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L57.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L58.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L59.png |
cbfda25
to
bfe3917
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ 💙 💚 💜 💛
Description
Disable compat mode and fully switch to Vue 3.
We're not completely there yet, but these are the minimum steps necessary to test it. The state is not perfect but it's looking quite good already. The application basically works and only a bunch of unit tests are broken (not taking minimal required snapshot updates into account).Related Issue
Motivation and Context
We should do this asap to definitely avoid introducing new incompatible code and to take full advantage of the better performance of Vue 3 - it should help especially with our resource table being very slow when listing a lot of files.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks:
compatConfig
s from Components@vue/compat
from package.json files (kept for now to ease switching of branches)vue-tsc