Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Vue 3: Disable compat mode #8288

Merged
merged 6 commits into from
Jan 23, 2023
Merged

[full-ci] Vue 3: Disable compat mode #8288

merged 6 commits into from
Jan 23, 2023

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Jan 21, 2023

Description

Disable compat mode and fully switch to Vue 3.

We're not completely there yet, but these are the minimum steps necessary to test it. The state is not perfect but it's looking quite good already. The application basically works and only a bunch of unit tests are broken (not taking minimal required snapshot updates into account).

Related Issue

Motivation and Context

We should do this asap to definitely avoid introducing new incompatible code and to take full advantage of the better performance of Vue 3 - it should help especially with our resource table being very slow when listing a lot of files.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Fix unit tests
    • Update Snapshots
    • Fix remaining tests
  • Fix acceptance tests (if broken 👀)
  • Remove left-over compatConfigs from Components
  • Remove @vue/compat from package.json files (kept for now to ease switching of branches)
  • Compare vite created stub project setup with ours, maybe we can learn anything smart - like ts or vite config
  • Enable vue-tsc

@update-docs
Copy link

update-docs bot commented Jan 21, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt marked this pull request as draft January 21, 2023 09:52
@dschmidt dschmidt force-pushed the vue3-switch branch 3 times, most recently from 2d21bc2 to aaa4f56 Compare January 21, 2023 10:26
@dschmidt dschmidt force-pushed the vue3-remove-vue-default-export branch from bc4599a to 40824fa Compare January 23, 2023 08:53
@delete-merged-branch delete-merged-branch bot deleted the branch master January 23, 2023 09:31
@dschmidt dschmidt changed the base branch from vue3-remove-vue-default-export to master January 23, 2023 09:35
@ownclouders
Copy link
Contributor

ownclouders commented Jan 23, 2023

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/31999/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L47.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L47.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L48.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L48.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L49.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L49.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L50.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L50.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L51.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L51.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L52.png

webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L52.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L54.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L54.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L55.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L55.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L56.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L56.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L57.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L57.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L58.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L58.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L59.png

webUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L59.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L54.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L54.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L55.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L55.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L56.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L56.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L57.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L57.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L58.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L58.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L59.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L59.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L60.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L60.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L61.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L61.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L62.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L62.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L63.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L63.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L64.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L64.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L65.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L65.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.png

@ownclouders
Copy link
Contributor

ownclouders commented Jan 23, 2023

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/31999/36/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L54.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L54.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L55.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L55.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L56.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L56.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L57.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L57.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L58.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L58.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L59.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L59.png

@dschmidt dschmidt changed the base branch from master to fix-vue3-warnings January 23, 2023 17:11
@dschmidt dschmidt force-pushed the vue3-switch branch 2 times, most recently from cbfda25 to bfe3917 Compare January 23, 2023 21:30
@delete-merged-branch delete-merged-branch bot deleted the branch master January 23, 2023 21:48
@kulmann kulmann changed the base branch from fix-vue3-warnings to master January 23, 2023 22:08
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@dschmidt dschmidt marked this pull request as ready for review January 23, 2023 22:33
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 💙 💚 💜 💛

@kulmann kulmann merged commit 923ff06 into master Jan 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the vue3-switch branch January 23, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants