Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Vue 3: Remove Vue default export/import usage #8287

Merged
merged 6 commits into from
Jan 23, 2023
Merged

[full-ci] Vue 3: Remove Vue default export/import usage #8287

merged 6 commits into from
Jan 23, 2023

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Jan 20, 2023 •
edited
Loading

Description

Vue 3 has no default export, hence we need to get rid of its usage.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jan 20, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt changed the title Vue 3: Remove Vue default export/import [full-ci] Vue 3: Remove Vue default export/import Jan 20, 2023
@dschmidt dschmidt force-pushed the vue3-remove-vue-default-export branch 2 times, most recently from 6d19192 to 345cc0d Compare January 20, 2023 15:44
@dschmidt dschmidt changed the title [full-ci] Vue 3: Remove Vue default export/import [full-ci] Vue 3: Remove Vue default export/import usage Jan 21, 2023
@dschmidt dschmidt mentioned this pull request Jan 21, 2023
Merged
17 tasks
@dschmidt dschmidt force-pushed the vue3-remove-vue-default-export branch from bc4599a to 40824fa Compare January 23, 2023 08:53
JammingBen
JammingBen approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

22.4% 22.4% Coverage
0.0% 0.0% Duplication

@dschmidt dschmidt merged commit 7d51f66 into master Jan 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the vue3-remove-vue-default-export branch January 23, 2023 09:31
ownclouders pushed a commit that referenced this pull request Jan 23, 2023
@dschmidt
commit 7d51f66
e0a5551 
Author: Dominik Schmidt <[email protected]>
Date:   Mon Jan 23 10:31:41 2023 +0100

    [full-ci] Vue 3: Remove Vue default export/import usage (#8287)

    * Remove Vue.set global usage

    * Vue 3: Get rid of Vue default import/export usage

    * Use types for resource computed

    * Replace FetchMock cast by just importing fetchMock

    * Remove default Vue export from TypeScript types

    * Fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschmidt @JammingBen