[full-ci] Fix Vue 3 warnings #8285
Conversation
JammingBen
force-pushed
the
fix-vue3-warnings
branch
from
236ca33 to
11d02dd
Compare
JammingBen
force-pushed
the
fix-vue3-warnings
branch
from
11d02dd to
3307caa
Compare
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/31987/22/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUITextEditor-textFile_feature-L21.pngwebUITextEditor-textFile_feature-L29.pngwebUITextEditor-textFile_feature-L50.pngwebUITextEditor-textFile_feature-L80.pngwebUITextEditor-textFile_feature-L81.pngwebUITextEditor-textFile_feature-L82.pngwebUITextEditor-textFile_feature-L83.pngwebUITextEditor-textFile_feature-L84.png |
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/31987/61/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUITextEditor-textFile_feature-L21.pngwebUITextEditor-textFile_feature-L29.pngwebUITextEditor-textFile_feature-L50.pngwebUITextEditor-textFile_feature-L80.pngwebUITextEditor-textFile_feature-L81.pngwebUITextEditor-textFile_feature-L82.pngwebUITextEditor-textFile_feature-L83.pngwebUITextEditor-textFile_feature-L84.png |
| AcceptShare, | ||
| Copy, | ||
| CreateQuicklink, | ||
| DeclineShare, | ||
| Delete, | ||
| DownloadArchive, | ||
| DownloadFile, | ||
| EmptyTrashBin, | ||
| Favorite, | ||
| Move, | ||
| Paste, | ||
| Navigate, | ||
| Rename, | ||
| Restore, | ||
| ShowActions, | ||
| ShowDetails, | ||
| ShowEditTags, |
There was a problem hiding this comment.
FYI: Those were registered twice because they are already included in the generic FileActions mixin.
dschmidt
force-pushed
the
fix-vue3-warnings
branch
2 times, most recently
from
a3bf55a to
3a51714
Compare
|
Kudos, SonarCloud Quality Gate passed! |
| data-testid="files-switch-hidden-files" | ||
| :label="$gettext('Show hidden files')" | ||
| @update:checked="updateHiddenFilesShownModel" |
There was a problem hiding this comment.
To my understand of https://v3-migration.vuejs.org/breaking-changes/v-model.html#migration-strategy the @update:checked event listener is not needed - at least with your implementation of the handler. It just updates the hiddenFilesShownModel data prop to the event value. According to the migration guide that is already the case for v-model:checked ( / v-model:whatever-custom-key).
| @@ -32,6 +32,7 @@ | |||
| @fileClick="$_fileActions_triggerDefaultAction" | |||
| @rowMounted="rowMounted" | |||
| @sort="handleSort" | |||
| @update:selectedIds="selectedResourcesIds = $event" | |||
There was a problem hiding this comment.
Same here again, the listener should not be needed.
| @@ -28,6 +28,7 @@ | |||
| @fileClick="$_fileActions_triggerDefaultAction" | |||
| @rowMounted="rowMounted" | |||
| @sort="sortHandler" | |||
| @update:selectedIds="selectedResourcesIds = $event" | |||
There was a problem hiding this comment.
Same here again, the listener should not be needed.
| @@ -29,6 +29,7 @@ | |||
| @fileClick="$_fileActions_triggerDefaultAction" | |||
| @rowMounted="rowMounted" | |||
| @sort="handleSort" | |||
| @update:selectedIds="selectedResourcesIds = $event" | |||
There was a problem hiding this comment.
Same here again, the listener should not be needed.
| @@ -30,6 +30,7 @@ | |||
| @fileClick="$_fileActions_triggerDefaultAction" | |||
| @rowMounted="rowMounted" | |||
| @sort="handleSort" | |||
| @update:selectedIds="selectedResourcesIds = $event" | |||
There was a problem hiding this comment.
Same here again, the listener should not be needed.
| @@ -63,6 +63,7 @@ | |||
| @fileClick="$_fileActions_triggerDefaultAction" | |||
| @rowMounted="rowMounted" | |||
| @sort="handleSort" | |||
| @update:selectedIds="selectedResourcesIds = $event" | |||
There was a problem hiding this comment.
Same here again, the listener should not be needed.
| @@ -36,6 +36,7 @@ | |||
| :space="space" | |||
| :has-actions="showActions" | |||
| @sort="handleSort" | |||
| @update:selectedIds="selectedResourcesIds = $event" | |||
There was a problem hiding this comment.
Same here again, the listener should not be needed.
Description
Fix Vue 3 compat warnings to finally reach compatibility with Vue 3. Key changes:
v-modelbehavior (value->modelValue), see https://v3-migration.vuejs.org/breaking-changes/v-model.html for more details.emits: []in each component.focus-trapto be compatible with Vue3.deep: truewhen watching arrays because this is required now.$setOcSelect).The changes regarding
compatConfigcan be ignored most likely because it will be removed with #8288 anyways.Related Issue
Types of changes