Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Design polishing #7684

Merged
merged 13 commits into from
Sep 29, 2022
Merged

[full-ci] Design polishing #7684

merged 13 commits into from
Sep 29, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 23, 2022

Related Issue

Screenshots:

  • Redesign spaces overview
    • Remove text and border line
    • Fix breadcrumb alignment
    • Show icon for sidebar
    • Use fixed width for cards
    • Align "Create Space"-button with "New" button in Personal Space
    • Use file-type="line" for members icon

image


  • Align spacing in left sidebar & breadcrumbs:
    • Horizontally align breadcrumbs with chevron in the left sidebar
    • Horizontally align the entries of the left sidebar with "Create"-Actions
    • Fix horizontal alignment of breadcrumbs and chevrons within

image


  • Reduce spacing between actions above file list

image


  • Space front page
    • Show default image on space overview
    • Give image a fixed width
    • Change default description to "Here you can add a description for this Space."
    • Make subtitle bold

image


  • Fix vertical height of the "There are no resources in this folder"-message (there was a vertical scrollbar before)
  • Adjust texts for enabling/disabling spaces (see Wording: Disable or enable a Space #7685)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@ownclouders
Copy link
Contributor

ownclouders commented Sep 23, 2022

Results for oC10Basic https://drone.owncloud.com/owncloud/web/28755/13/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIWebdavLockProtection-move_feature-L59.png

webUIWebdavLockProtection-move_feature-L59.png

webUIWebdavLockProtection-move_feature-L60.png

webUIWebdavLockProtection-move_feature-L60.png

@JammingBen JammingBen changed the title Design polishing [full-ci] Design polishing Sep 26, 2022
@tbsbdr
Copy link

tbsbdr commented Sep 26, 2022

Please note: the Space name gets truncated too early imo. if there is enough space, it should not get truncated

@kulmann
Copy link
Contributor

kulmann commented Sep 27, 2022

Does it also fix #7694 ?

@kulmann
Copy link
Contributor

kulmann commented Sep 27, 2022

and #7693 ?

@JammingBen JammingBen marked this pull request as ready for review September 29, 2022 12:24
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.9% 25.9% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks much better. Thank you!
The no content message still is not ideal. E.g. in a project space with an image and a long description I get a quite long scrollbar. But that can be solved in a separate PR... I changed the PR description to not claim to fix #7693 anymore.

@kulmann kulmann merged commit 76e9c4d into master Sep 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the design-polishing branch September 29, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants