Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paddings inconsistent on various menus #7525

Closed
elizavetaRa opened this issue Aug 25, 2022 · 5 comments · Fixed by #8859
Closed

Paddings inconsistent on various menus #7525

elizavetaRa opened this issue Aug 25, 2022 · 5 comments · Fixed by #8859
Assignees
Labels
Early-Adopter:CERN Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@elizavetaRa
Copy link
Member

elizavetaRa commented Aug 25, 2022

Padding sizes are inconsistent for highlighted elements in the nav bar, the roles drop, the user menu and the apps menu

Screenshot from 2022-08-25 11-09-45

Screenshot from 2022-08-25 11-05-19

Screenshot from 2022-08-25 11-05-58

@diocas
Copy link
Contributor

diocas commented Aug 26, 2022

Sorry for piggy backing on this "padding issue" (maybe we can rename it to something more generic), but here are a couple more issues:

  • Breadcrumb is no longer vertically centered (maybe the chevrons could be smaller?)
    Screenshot 2022-08-26 at 15 27 18
  • Space between batch action buttons could be smaller?
  • The config menu inside the files app is not very consistent with the others (the new ones have a bit more padding/spacing)
    Screenshot 2022-08-26 at 15 28 30
  • Small detail, but if we reduced the collapse button on the left sidebar, then the "all files" button would vertically align with the "new" and "upload" buttons which would be nicer (although it looks like they don't have the exact same height)
    Screenshot 2022-08-26 at 15 29 35

@JammingBen
Copy link
Contributor

Closing here because the paddings have been aligned meanwhile. We didn't change anything in the account- and the share-role-dropdown though. Increasing the padding for items that have some additional info in a separate line would make the items differ in height, resulting in an even more uneven view IMO.

@diocas
Copy link
Contributor

diocas commented Apr 18, 2023

There were no suggestions of increasing the padding. Most of the elements have been fixed, but not all.

The inconsistencies that are still present:

  • too much top/bottom padding on first/last button in dropdowns, in comparison with sides (applies to both roles dropdown in the sharing pane and the account dropdown)
    • this happens because every button has top + bottom padding, which should not happen in :first-* (top) and :last-* (bottom)
  • In the account dropdown, the button with Username + email doesn't have a consistent spacing between the lines. This has been fixed and look very well in the roles menu (where it has the role name and description)

I still think this should be fixed (and it doesn't seem very hard), but I leave to your consideration.

edit: it's not padding but margin on li's margin: var(--oc-space-xsmall) 0;

@JammingBen
Copy link
Contributor

too much top/bottom padding on first/last button in dropdowns, in comparison with sides (applies to both roles dropdown in the sharing pane and the account dropdown)

Ahh okay, didn't get that initially. But you're right, there is an inconsistency.

In the account dropdown, the button with Username + email doesn't have a consistent spacing between the lines. This has been fixed and look very well in the roles menu (where it has the role name and description)

Not 100% sure here, you mean like this (basically decreasing the spacing between the username and the email)?

image

@JammingBen JammingBen reopened this Apr 18, 2023
@diocas
Copy link
Contributor

diocas commented Apr 18, 2023

Not 100% sure here, you mean like this (basically decreasing the spacing between the username and the email)?

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early-Adopter:CERN Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants