Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various spacings #8859

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Fix various spacings #8859

merged 2 commits into from
Apr 25, 2023

Conversation

JammingBen
Copy link
Contributor

Description

  • Adjust line height in account menu dropdown
  • Reduce margin-top/bottom on first and last items in several dropdowns:
    • Account menu
    • App switcher
    • Sharing role select
    • User filter

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Apr 19, 2023
@update-docs
Copy link

update-docs bot commented Apr 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

lookacat
lookacat suggested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo, code/styling LGTM

@JammingBen
Copy link
Contributor Author

Thx for the hint, fixed :) Changelog is not necessary here, it's just a really small visual change and the changelogs for 7.0. went through the roof already.

@JammingBen JammingBen requested a review from lookacat April 20, 2023 15:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lookacat
lookacat approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JammingBen JammingBen merged commit c6df433 into master Apr 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-various-spacings branch April 25, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paddings inconsistent on various menus
2 participants
@JammingBen @lookacat