[full-ci] Initial implementation of archiver v2 #5832
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
force-pushed
the
archive-download
branch
from
bde5577 to
56aa196
Compare
kulmann
force-pushed
the
archive-download
branch
from
b26cd4e to
c169c63
Compare
packages/web-app-files/src/components/AppBar/SelectedResources/BatchActions.vue
Outdated
Show resolved
Hide resolved
kulmann
force-pushed
the
archive-download
branch
from
447a714 to
be68ccd
Compare
kulmann
changed the title
kulmann
force-pushed
the
archive-download
branch
2 times, most recently
from
8d5faf0 to
9a115d9
Compare
kulmann
force-pushed
the
archive-download
branch
from
0c7ea9a to
4c6d0ad
Compare
|
Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/19381/25/1
|
| @@ -19,6 +19,7 @@ Background: prepare user and files | |||
| And only the following items with default items should be visible in the actions menu on the webUI | |||
| | items | | |||
| | open folder | | |||
| | download folder | | |||
There was a problem hiding this comment.
this test fails AssertionError [ERR_ASSERTION]: only 'open folder,download folder' actions menu item(s) was expected to be visible but found 'open folder' instead.
| copyButton = wrapper.find(elSelector.copyButton) | ||
| moveButton = wrapper.find(elSelector.moveButton) | ||
| deleteButton = wrapper.find(elSelector.deleteButton) | ||
| }) | ||
|
|
||
| it('should display the action buttons', () => { | ||
| expect(actionButtons.length).toEqual(3) | ||
| expect(downloadButton.exists()).toBeTruthy() |
There was a problem hiding this comment.
Shouldn't checking for the text of an element be enough (test fails if it doesn't exist since it can't find the text)?
| it('is announcing itself as available', () => { | ||
| expect(service.available).toBe(true) | ||
| }) | ||
| it('uses the highest major version', () => { |
There was a problem hiding this comment.
| it('uses the highest major version', () => { | |
| it('uses the highest major version that is enabled', () => { |
Optional clarification
| @@ -19,6 +19,7 @@ Background: prepare user and files | |||
| And only the following items with default items should be visible in the actions menu on the webUI | |||
| | items | | |||
| | open folder | | |||
| | download folder | | |||
There was a problem hiding this comment.
Seems to fail in a OC10 pipeline which makes sense (since the download action doesn't get rendered into those actions based on capabilities?)
There was a problem hiding this comment.
will that be added in oc10? If yes, then the test need to he added to the expected to fail list, if not, need to split the scenario and one tagged with @skipOnOC10 and one with @notToImplementOnOCIS
fschade
force-pushed
the
archive-download
branch
from
2f736b9 to
a11c59e
Compare
…nd and boot logic needs to be improved. oids-callback page is in vue so the mounted hook was already called.
fschade
force-pushed
the
archive-download
branch
from
614172c to
926863c
Compare
|
SonarCloud Quality Gate failed. |
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19427/12/1
|
Initial implementation of archiver v2 (REVA) for authenticated contexts. Public links are not supported, yet.
Description
Related Issue
Motivation and Context
Being able to download folders
How Has This Been Tested?
Types of changes
Checklist:
Open tasks:
webUIFilesActionMenu/fileFolderActionMenu.feature:14into an oCIS and an oC10 test (archiver only exists with ocis)move archiverService initialization to theinitializehook once [full-ci] Init store and auth as early as possible #5874 is merged