Add space front page & bump SDK to `v2.0.0` #6287

AlexAndBear · 2022-01-20T09:04:25Z

Description

Implemented the front page for spaces
Use the SDK v2

To create an image and a readme for a space, you have to do a few things. First, create a yaml file locally with the following content:

---
version: "1.0"
description: fooooo ooo
special:
  readme: readme.md
  image: space.png

The paths to the readme and the image are relative to the root directory of the space.
Then, run the following curls. Note that you need basic auth enabled in ocis (PROXY_ENABLE_BASIC_AUTH=true):

curl -k -X MKCOL 'https://localhost:9200/dav/spaces/fe1f3db7-d7bf-4695-b222-91875c79b2e7/.config' -u admin:admin
curl -k -X MKCOL 'https://localhost:9200/dav/spaces/fe1f3db7-d7bf-4695-b222-91875c79b2e7/.config/ocis' -u admin:admin
curl -k -X PUT 'https://localhost:9200/dav/spaces/fe1f3db7-d7bf-4695-b222-91875c79b2e7/.config/ocis/space.yaml' -u admin:admin -v -T space.yaml

Expected failures:

~~Changing the description of a space from the spaces list does not work~~
Sharing within a space does not work (maybe it shouldn't, but then we would need to hide the actions)
Some of the breadcrumb actions on a space itself need to be removed/hidden as they make no sense (e.g. move, copy)
The breadcrumbs currently show the space ID, not the space name
The space ID in the breadcrumb cannot be clicked when you are on the front page of the space (which would normally trigger a reload)
Thumbnails do not work within a space

Related Issue

Display Frontpage of a single Space #6271
Fixes Bump ownCloud-SDK package #6146 (at least the web parts of it)

Screenshots:

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

...

update-docs · 2022-01-20T09:04:29Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

packages/web-app-files/package.json

ownclouders · 2022-01-31T15:53:55Z

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/22305/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2022-02-01T10:34:22Z

Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/22317/42/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2022-02-01T14:45:53Z

Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/22333/43/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

packages/web-app-files/src/components/AppBar/AppBar.vue

packages/web-app-files/src/components/FilesList/NotFoundMessage.vue

packages/web-runtime/package.json

pascalwengerter · 2022-02-04T09:44:13Z

Some early findings

space id (?) instead of space name shows up in breadcrumbs
normal folder actions show up in breadcrumbs context menu (IIRC you can't move/download a space for example)
batch actions above heading seem counter-intuitive, not sure if that's part of the screendesign? I'd expect the order to be heading => batch-actions (= also can be the "New" icon) => resource-table :)

pascalwengerter · 2022-02-04T09:52:33Z

{{space.description}} is empty/not being displayed for me, even after pulling the latest oCIS docker image and setting it via the UI 😰

ownclouders · 2022-02-04T09:55:45Z

Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/22453/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersToRootPreviews-shareWithUsers_feature-L11.png

webUISharingInternalUsersToRootPreviews-shareWithUsers_feature-L25.png

ownclouders · 2022-02-04T09:56:16Z

Results for oC10SharingIntUsers2 https://drone.owncloud.com/owncloud/web/22453/30/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersToRoot-shareWithUsers_feature-L179.png

webUISharingInternalUsersToRoot-shareWithUsers_feature-L193.png

webUISharingInternalUsersToRoot-shareWithUsers_feature-L258.png

ownclouders · 2022-02-04T09:56:36Z

Results for oC10SharingIntGroups https://drone.owncloud.com/owncloud/web/22453/27/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

webUISharingInternalGroups-shareWithGroups_feature-L77.png

ownclouders · 2022-02-04T09:56:54Z

Results for oCISSharingInternal1 https://drone.owncloud.com/owncloud/web/22453/59/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

ownclouders · 2022-02-04T09:57:35Z

Results for oCISFiles3 https://drone.owncloud.com/owncloud/web/22453/57/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIRenameFiles-renameFiles_feature-L246.png

ownclouders · 2022-02-04T09:58:31Z

Results for oC10SharingIntUsers1 https://drone.owncloud.com/owncloud/web/22453/29/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers_feature-L108.png

webUISharingInternalUsers-shareWithUsers_feature-L180.png

webUISharingInternalUsers-shareWithUsers_feature-L195.png

webUISharingInternalUsers-shareWithUsers_feature-L319.png

ownclouders · 2022-02-09T09:11:38Z

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22575/60/1
The following scenarios passed on retry:

webUISharingInternalUsers/shareWithUsers.feature:342

kulmann

Some more nagging on the action mixin implementation 😁 Thanks for taking care of all of this! ❤️

packages/web-app-files/src/mixins/spaces/actions/delete.js

packages/web-app-files/src/mixins/spaces/actions/disable.js

packages/web-app-files/src/mixins/spaces/actions/rename.js

packages/web-app-files/src/mixins/spaces/actions/restore.js

packages/web-app-files/src/mixins/spaces/actions/delete.js

packages/web-app-files/src/mixins/spaces/actions/disable.js

packages/web-app-files/src/mixins/spaces/actions/editDescription.js

packages/web-app-files/src/mixins/spaces/actions/rename.js

packages/web-app-files/src/mixins/spaces/actions/restore.js

sonarcloud · 2022-02-09T10:04:59Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
1 Security Hotspot
14 Code Smells

49.7% Coverage
4.7% Duplication

kulmann

You guys are awesome 🚀 🥇

packages/web-app-files/src/mixins/spaces/actions/delete.js

JammingBen force-pushed the space-frontpage branch from 5b83694 to 7d7f45d Compare January 20, 2022 12:58

AlexAndBear force-pushed the space-frontpage branch from d1f7adc to 9b0f6cc Compare January 26, 2022 11:50

JammingBen force-pushed the space-frontpage branch from 520de6f to 59ba48f Compare January 28, 2022 12:17

AlexAndBear force-pushed the space-frontpage branch from d101b56 to 056ccb4 Compare January 31, 2022 15:01

JammingBen reviewed Jan 31, 2022

View reviewed changes

packages/web-app-files/package.json Show resolved Hide resolved

AlexAndBear requested a review from pascalwengerter February 1, 2022 10:44

AlexAndBear assigned AlexAndBear and JammingBen Feb 1, 2022

AlexAndBear requested a review from kulmann February 1, 2022 10:44

kulmann marked this pull request as ready for review February 1, 2022 13:08

kulmann requested a review from fschade as a code owner February 1, 2022 13:08

JammingBen force-pushed the space-frontpage branch from 85299c7 to d18242e Compare February 1, 2022 13:48

kulmann reviewed Feb 2, 2022

View reviewed changes

packages/web-app-files/src/components/AppBar/AppBar.vue Outdated Show resolved Hide resolved

packages/web-app-files/src/components/FilesList/NotFoundMessage.vue Outdated Show resolved Hide resolved

JammingBen force-pushed the space-frontpage branch from f69f15b to 9eaf76d Compare February 3, 2022 12:10

AlexAndBear force-pushed the space-frontpage branch from 9eaf76d to d76b610 Compare February 3, 2022 13:34

pascalwengerter reviewed Feb 3, 2022

View reviewed changes

packages/web-runtime/package.json Outdated Show resolved Hide resolved

AlexAndBear force-pushed the space-frontpage branch from d76b610 to bcc83af Compare February 4, 2022 06:38

AlexAndBear changed the title ~~Add space front page~~ [full-ci] Add space front page Feb 4, 2022

JanAckermann and others added 14 commits February 9, 2022 08:50

update yarn.lock

687367f

Update snapshot

9086b65

Fix media viewer, run linter

7e3fb97

Update snapshot

dafce73

Adjustments

c8351a6

Adjustments

349265d

Update snapshots

90cea3f

Add changelog item

69aecfb

Fix drag and drop move file in all files list

1fb0d8e

Remove unwanted console.log

1e3ccf6

Remove unwanted console.log

7ba0181

Minor fixes according to code review

91bf5fe

Fix integration tests

120bb76

Fix resize observer on breadcrumb navigation

9ea2695

JammingBen force-pushed the space-frontpage branch from 0c889fb to 9ea2695 Compare February 9, 2022 08:43

kulmann mentioned this pull request Feb 9, 2022

Move the watchActiveLocation helper to a useActiveLocation composable #6393

Merged

9 tasks

kulmann requested changes Feb 9, 2022

View reviewed changes

JammingBen and others added 3 commits February 9, 2022 10:28

Adjust early returns in mixins

8e41ca7

Remove uneccerssary headline

6b7ee19

Update snapshot

1ee31b8

pascalwengerter requested a review from kulmann February 9, 2022 11:02

kulmann approved these changes Feb 9, 2022

View reviewed changes

packages/web-app-files/src/mixins/spaces/actions/delete.js Show resolved Hide resolved

kulmann merged commit d582e2b into master Feb 9, 2022

JammingBen mentioned this pull request Feb 10, 2022

Display Frontpage of a single Space #6271

Closed

individual-it mentioned this pull request Feb 11, 2022

[tests-only] set user object in LocationPicker unit tests #6420

Merged

10 tasks

diocas mentioned this pull request Feb 17, 2022

Fix file creation #6449

Merged

dschmidt mentioned this pull request Feb 19, 2022

[full-ci] Fix several file handling issues for apps #6456

Merged

10 tasks

pascalwengerter deleted the space-frontpage branch February 25, 2022 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add space front page & bump SDK to `v2.0.0` #6287

Add space front page & bump SDK to `v2.0.0` #6287

AlexAndBear commented Jan 20, 2022 •

edited by JammingBen

Loading

update-docs bot commented Jan 20, 2022

ownclouders commented Jan 31, 2022

ownclouders commented Feb 1, 2022

ownclouders commented Feb 1, 2022

pascalwengerter commented Feb 4, 2022 •

edited

Loading

pascalwengerter commented Feb 4, 2022

ownclouders commented Feb 4, 2022

webUISharingInternalUsersToRootPreviews-shareWithUsers_feature-L11.png

webUISharingInternalUsersToRootPreviews-shareWithUsers_feature-L25.png

ownclouders commented Feb 4, 2022

webUISharingInternalUsersToRoot-shareWithUsers_feature-L179.png

webUISharingInternalUsersToRoot-shareWithUsers_feature-L193.png

webUISharingInternalUsersToRoot-shareWithUsers_feature-L258.png

ownclouders commented Feb 4, 2022

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

webUISharingInternalGroups-shareWithGroups_feature-L77.png

ownclouders commented Feb 4, 2022

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

ownclouders commented Feb 4, 2022

webUIRenameFiles-renameFiles_feature-L246.png

ownclouders commented Feb 4, 2022

webUISharingInternalUsers-shareWithUsers_feature-L108.png

webUISharingInternalUsers-shareWithUsers_feature-L180.png

webUISharingInternalUsers-shareWithUsers_feature-L195.png

webUISharingInternalUsers-shareWithUsers_feature-L319.png

ownclouders commented Feb 9, 2022

kulmann left a comment

sonarcloud bot commented Feb 9, 2022

kulmann left a comment

Add space front page & bump SDK to v2.0.0 #6287

Add space front page & bump SDK to v2.0.0 #6287

Conversation

AlexAndBear commented Jan 20, 2022 • edited by JammingBen Loading

Description

Expected failures:

Related Issue

Screenshots:

Types of changes

Checklist:

Open tasks:

update-docs bot commented Jan 20, 2022

ownclouders commented Jan 31, 2022

ownclouders commented Feb 1, 2022

ownclouders commented Feb 1, 2022

pascalwengerter commented Feb 4, 2022 • edited Loading

pascalwengerter commented Feb 4, 2022

ownclouders commented Feb 4, 2022

webUISharingInternalUsersToRootPreviews-shareWithUsers_feature-L11.png

webUISharingInternalUsersToRootPreviews-shareWithUsers_feature-L25.png

ownclouders commented Feb 4, 2022

webUISharingInternalUsersToRoot-shareWithUsers_feature-L179.png

webUISharingInternalUsersToRoot-shareWithUsers_feature-L193.png

webUISharingInternalUsersToRoot-shareWithUsers_feature-L258.png

ownclouders commented Feb 4, 2022

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

webUISharingInternalGroups-shareWithGroups_feature-L77.png

ownclouders commented Feb 4, 2022

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

ownclouders commented Feb 4, 2022

webUIRenameFiles-renameFiles_feature-L246.png

ownclouders commented Feb 4, 2022

webUISharingInternalUsers-shareWithUsers_feature-L108.png

webUISharingInternalUsers-shareWithUsers_feature-L180.png

webUISharingInternalUsers-shareWithUsers_feature-L195.png

webUISharingInternalUsers-shareWithUsers_feature-L319.png

ownclouders commented Feb 9, 2022

kulmann left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Feb 9, 2022

kulmann left a comment

Choose a reason for hiding this comment

Add space front page & bump SDK to `v2.0.0` #6287

Add space front page & bump SDK to `v2.0.0` #6287

AlexAndBear commented Jan 20, 2022 •

edited by JammingBen

Loading

pascalwengerter commented Feb 4, 2022 •

edited

Loading