-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archiver and app provider capabilities #2529
Conversation
For the archiver, it has a maximum number of files and a maximum size that I think they should be in the capabilities. The client could prevent requests that we know that will fail. |
62fa497
to
7f38afb
Compare
Good point 👍 Needs changes in REVA though... |
Yes, good idea for improvement 👍 but please let's get this PR merged first, then improve it (IMO right away ;-) ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the changes in the go.mod file, but the rest looks good to me.
7f38afb
to
2eee954
Compare
Co-authored-by: Pascal Wengerter <[email protected]>
2eee954
to
8bc8f46
Compare
Co-authored-by: Benedikt Kulmann <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Adds the archiver and app provider to the ocs capabilities.
Removes unused structs, which already live in REVA
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: