-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add archiver and app provider capabilities #2088
add archiver and app provider capabilities #2088
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@wkloucek can you fix the linter error? |
@wkloucek is this ready for review? still marked as a draft PR. |
@@ -110,6 +126,8 @@ type CapabilitiesFiles struct { | |||
Favorites ocsBool `json:"favorites" xml:"favorites"` | |||
BlacklistedFiles []string `json:"blacklisted_files" xml:"blacklisted_files>element" mapstructure:"blacklisted_files"` | |||
TusSupport *CapabilitiesFilesTusSupport `json:"tus_support" xml:"tus_support" mapstructure:"tus_support"` | |||
Archivers []*CapabilitiesArchiver `json:"archivers" xml:"archivers" mapstructure:"archivers"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are multiple archiver or app provider versions available from the backend, how do I know which one is the most recent one? By parsing the versions? Or do you think it makes sense to introduce some MostRecent
boolean in the respective capability struct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my PoC I'm using http://npmjs.com/semver to sort the available versions (which also works with strings like |
Merging it now. Other parameters can be added in separate PRs. |
No description provided.