[web] Shared with me: Show / Hide shares

[exalate-issue-sync]

Description

User Stories

• As a user I want to hide unwanted shares so that I can keep an overview over my shares.

• As a user I want to unsync shares so that my local disk space does not get full.

• As a user I want to sync selected shares so that I can access these files on my devices.

Value

Acceptance Criteria

• All incoming shares are initally shown in "Shared with me" (no more "Accepted- Pending- and Declined shares sections")
• All shares have a new status "visible" or "hidden" (so that users can tidy up unwanted shares); default is "visible"
• oc10: status visible/hidden is not existent and all accepted/declined shares are shown in a single view.
• click on "hide" on a share hides the share
• click on "unhide" shows the share
• Button group "Shares" and "Hidden Shares"
  • Click on the respective button shows either shares with the status "hidden" or "unhidden"
• If autoaccept is serverside
  • enabled, all shares are synced with the mobile& desktop clients
  • disabled, all shares are not automatically available in the mobile and desktop clients
• New button per share: "Enable sync" / "Disable sync" syncs/unsync the share with mobile & desktop clients
  • If a share is "hidden", it still can get get enabled/disabled for syncing (cc @elizavetaRa @diocas @pascalwengerter )
  • "Enable sync" = ~ "Accept share"
  • "Disable sync" = ~ "Pending" for initial incoming shares
  • "Disable sync" = ~ "Decline" if share is not in initial pending state

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

• Functional requirements
  [ ] functionality described in the user story works
  [ ] acceptance criteria are fulfilled
• Quality
  [ ] code review happened
  [ ] CI is green
  [ ] critical code received unit tests by the developer
  [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
• Non-functional requirements
  [ ] no sonar cloud issues

Screenshots

Initial View

• Shows visible shares
• quickaction to Hide shares
• Status column shows, if Sync with devices is enabled
• enable sync via batch action or context menu

Hidden Shares

• Toggle button shows hidden shares
• If a share gets hidden, it can still get snyced/unsynced.
  

[exalate-issue-sync]

Florian Schade commented: [~mstingl] FYI, maybe for the clients?

[tbsbdr]

Updated ACs in initial post

• If a share is "hidden", it still can get get enabled/disabled for syncing
• Updated wording (in consultation of @TheOneRing )
  • Sync Unsync -> Enable sync Disable sync

[pascalwengerter]

@tbsbdr which icons from https://owncloud.design/#/Design%20Tokens/IconList to use for Enable sync/Disable sync actions? Or do you have custom ones in mind?

[tbsbdr]

hm.. yeah. a custom one would be good but for now I'd propose to use computer-line (for both, enable and disable)

[tbsbdr]

Note from weekly exchange cern & oc:

• we discussed to go with the approach "If a share is 'hidden', it still can get get enabled/disabled for syncing"
• it could be useful to provide a dialog: click: hide share -> dialog "Do you want to disable sync? [yes] [No]" but this dialog is not part of this story - first we would like to observe how the "hide" and "sync" options are getting adapted by users