align owncloud master against main

[dragonchaser]

No description provided.

[glpatcern]

@diocas how did we implement hiding of shares in CERNBox without this?

[glpatcern]

Following direct chats with @diocas and @gmgigi96 : the current implementation uses the state of a ReceivedShare, such that REJECTED shares are hidden, and others are visible.
This field seems then redundant, unless we want to express (received) shares that are APPROVED but hidden, or REJECTED but visible.
Also, an outgoing Share does not have a state and does not need to be hidden?

[micbar]

@glpatcern

As I understand it, it is a CERN feature request to have two flags on each share

1. Accepted
2. Hidden

[micbar]

We already implemented it on the backend and the web client for the CERN merge.

[glpatcern]

@micbar not sure the two flags were understood to be independent, i.e. with the 4 combinations being meaningful. Anyway even assuming so, that still concerns the ReceivedShare, not the Share, right?

[micbar]

User story owncloud/web#9531

[glpatcern]

Thanks, understood. I see the idea is also to observe adoption of those combinations and potentially simplify in the future.

With that, I think it's fine to add a hidden bool field to the ReceivedShare, next to (and indeed independent from) state. The Share structure/message should not be affected instead. Or do I miss something else?

[dragonchaser]

I will move it to ReceivedShare then....
I have set the PR to Draft for now, I want to make the necessary changes to reva/edge and merge it at the same time to avoid larger breakage.

[glpatcern]

That's fine, once you're ready with reva/edge this can be merged - and we'll adapt reva/master as well.

[dragonchaser]

We have a PR for edge: cs3org/reva#4256

[dragonchaser]

@glpatcern if you want you can merge it :)