-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework hidden shares #4256
Merged
Merged
Rework hidden shares #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dragonchaser
force-pushed
the
rework-hidden-shares
branch
2 times, most recently
from
October 18, 2023 11:42
875bd2b
to
832157f
Compare
kobergj
reviewed
Oct 18, 2023
dragonchaser
force-pushed
the
rework-hidden-shares
branch
from
October 18, 2023 15:13
2c2c034
to
e7acea6
Compare
dragonchaser
force-pushed
the
rework-hidden-shares
branch
4 times, most recently
from
October 20, 2023 09:36
9230cef
to
f844896
Compare
dragonchaser
requested review from
labkode,
ishank011,
a team and
glpatcern
as code owners
October 20, 2023 09:52
dragonchaser
force-pushed
the
rework-hidden-shares
branch
from
October 20, 2023 09:54
f844896
to
3107f78
Compare
aduffeck
reviewed
Oct 23, 2023
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/pending.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Co-authored-by: André Duffeck <[email protected]> Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
rework-hidden-shares
branch
from
October 23, 2023 13:38
3107f78
to
f1610ef
Compare
dragonchaser
force-pushed
the
rework-hidden-shares
branch
from
October 23, 2023 14:03
f1610ef
to
cefb4cd
Compare
Co-authored-by: Julian Koberg <[email protected]> Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
rework-hidden-shares
branch
from
October 24, 2023 07:07
cefb4cd
to
ae3f440
Compare
Signed-off-by: Christian Richter <[email protected]>
aduffeck
approved these changes
Oct 24, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Rename hidden share variable name
We have renamed the hidden flag on shares from Hide -> Hidden to align to the cs3api
see cs3org/cs3apis#214