Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add test for search project space files by content #6987

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[tests-only][full-ci]add test for search project space files by content #6987

merged 1 commit into from
Aug 10, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Aug 8, 2023 •
edited
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search files through a content. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Aug 8, 2023
@nabim777 nabim777 force-pushed the search-project-files-by-content branch 2 times, most recently from 402bd5a to 91948a0 Compare August 8, 2023 10:32
@nabim777 nabim777 mentioned this pull request Aug 8, 2023
Closed
51 tasks
saw-jan
saw-jan reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT SwikritiT mentioned this pull request Aug 9, 2023
Merged
9 tasks
@nabim777 nabim777 force-pushed the search-project-files-by-content branch from 91948a0 to d5762f2 Compare August 10, 2023 04:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 052710d into master Aug 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-project-files-by-content branch August 10, 2023 07:40
ownclouders pushed a commit that referenced this pull request Aug 10, 2023
@phil-davis
Merge pull request #6987 from owncloud/search-project-files-by-content
ca7c279 
[tests-only][full-ci]add test for search project space files by content
@nabim777 nabim777 mentioned this pull request Aug 15, 2023
Merged
@nabim777 nabim777 mentioned this pull request May 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @phil-davis @SagarGi @saw-jan @amrita-shrestha