Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test setup & test implementation #12

Merged
merged 132 commits into from
Jul 19, 2024
Merged

Conversation

koebel
Copy link
Contributor

@koebel koebel commented Mar 15, 2024

Description

  • setup for e2e tests
  • implementing tests scenario steps

IMPORTANT:
Scenario steps relating to assertion if object modifications like zoom and rotation have been applied haven't yet been implemented in this PR and it seems like assertions regarding position of model, etc. might not even be possible. According to this blog Playwright doesn't offer specific support for interaction with WebGL. WebGL is just rendered as canvas element in HTML, with which the user can interact with using the mouse and script it using JavaScript. However it seems like the actual model is not accessible through HTML. Therefore these steps of the scenario have been removed for now and a new issue has been created for this, see #15

Related Issue

Motivation and Context

add test coverage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@koebel koebel mentioned this pull request Mar 15, 2024
3 tasks
Copy link

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts from me. But I am not regularly working on these kind of UI tests, so please let me know any better ideas/conventions/standards.

package.json Outdated Show resolved Hide resolved
tests/e2e/pageObjects/Ocis.ts Outdated Show resolved Hide resolved
tests/e2e/pageObjects/Viewer.ts Outdated Show resolved Hide resolved
tests/e2e/steps/ViewerContext.ts Outdated Show resolved Hide resolved
tests/e2e/steps/ViewerContext.ts Outdated Show resolved Hide resolved
tests/e2e/utils/helpers.ts Outdated Show resolved Hide resolved
tests/e2e/utils/helpers.ts Outdated Show resolved Hide resolved
@koebel koebel requested a review from phil-davis July 15, 2024 10:14
@koebel koebel requested a review from amrita-shrestha July 15, 2024 10:34
@koebel koebel changed the title e2e test setup & test implementation [WiP] e2e test setup & test implementation Jul 16, 2024
Copy link
Owner

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to merge it as it is now.
Thank you for your effort 👍

@saw-jan saw-jan merged commit 7a1862f into saw-jan:master Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants