-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test setup & test implementation #12
Conversation
…splay mode still needs to be implemented properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts from me. But I am not regularly working on these kind of UI tests, so please let me know any better ideas/conventions/standards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to merge it as it is now.
Thank you for your effort 👍
Description
IMPORTANT:
Scenario steps relating to assertion if object modifications like zoom and rotation have been applied haven't yet been implemented in this PR and it seems like assertions regarding position of model, etc. might not even be possible. According to this blog Playwright doesn't offer specific support for interaction with WebGL. WebGL is just rendered as canvas element in HTML, with which the user can interact with using the mouse and script it using JavaScript. However it seems like the actual model is not accessible through HTML. Therefore these steps of the scenario have been removed for now and a new issue has been created for this, see #15
Related Issue
Motivation and Context
add test coverage
Screenshots (if appropriate):
Types of changes
Checklist: