Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] added test scenario for searching inside folder in shares #6982

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

KarunAtreya
Copy link
Contributor

Description

This PR adds Api test for searching inside current folder in shares(Location Filter). Following scenario is added:

  • user can search inside folder in shares

Related Issue

#6606

Motivation and Context

There is no test coverage for api test for searching by enabling current folder on where files and folders are searched inside that particular folder in shares

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder-shares branch 3 times, most recently from f6c09c0 to 35bf788 Compare August 8, 2023 08:58
@KarunAtreya KarunAtreya requested a review from SwikritiT August 8, 2023 10:28
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder-shares branch 2 times, most recently from 46016f1 to 852f8d0 Compare August 8, 2023 10:50
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder-shares branch 2 times, most recently from e5d8190 to e6d389e Compare August 9, 2023 03:59
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder-shares branch 2 times, most recently from 504c16c to b5ea953 Compare August 9, 2023 04:05
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder-shares branch from b5ea953 to 0b1c4a3 Compare August 14, 2023 07:11
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder-shares branch from 0b1c4a3 to 5b78af2 Compare August 14, 2023 09:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit 9971872 into master Aug 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-inside-current-folder-shares branch August 16, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants