Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Extend space download tests coverage #6854

Merged
merged 1 commit into from
Jul 24, 2023
Merged

[tests-only][full-ci] Extend space download tests coverage #6854

merged 1 commit into from
Jul 24, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR is follow-up PR of #6683 to add more tests related to space download

Related Issue

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Jul 20, 2023
@amrita-shrestha amrita-shrestha mentioned this pull request Jul 20, 2023
Closed
51 tasks
@delete-merged-branch delete-merged-branch bot deleted the branch stable-3.0 July 20, 2023 09:02
@amrita-shrestha amrita-shrestha force-pushed the add-more-test-coverage-for-space-download branch from 35acb8a to 4495dd1 Compare July 20, 2023 10:23
@amrita-shrestha amrita-shrestha changed the base branch from download-space to stable-3.0 July 20, 2023 10:24
@amrita-shrestha amrita-shrestha requested review from saw-jan and removed request for phil-davis, individual-it, micbar and wkloucek July 20, 2023 11:01
phil-davis
phil-davis reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests LGTM. Just one suggestion for a scenario description.

tests/acceptance/features/apiDownloads/spaceDownload.feature Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the add-more-test-coverage-for-space-download branch 2 times, most recently from 26cdad9 to 37ffc5e Compare July 24, 2023 03:20
@amrita-shrestha amrita-shrestha force-pushed the add-more-test-coverage-for-space-download branch from 37ffc5e to 9f9a5c0 Compare July 24, 2023 05:45
@amrita-shrestha amrita-shrestha requested a review from saw-jan July 24, 2023 05:45
saw-jan
saw-jan reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrita-shrestha amrita-shrestha force-pushed the add-more-test-coverage-for-space-download branch from 9f9a5c0 to ea2bcef Compare July 24, 2023 08:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

@amrita-shrestha this PR is to stable-3.0
Will you forward-port it to master?

@saw-jan saw-jan merged commit 5351ae8 into stable-3.0 Jul 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-more-test-coverage-for-space-download branch July 24, 2023 10:27
ownclouders pushed a commit that referenced this pull request Jul 24, 2023
@amrita-shrestha
Add more tests coverage (#6854)
022e164
amrita-shrestha added a commit that referenced this pull request Jul 25, 2023
@amrita-shrestha
Add more tests coverage (#6854)
6900a80
@amrita-shrestha amrita-shrestha mentioned this pull request Jul 25, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@phil-davis phil-davis phil-davis approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrita-shrestha @phil-davis @saw-jan