[tests-only] [full-ci] add test for downloading space #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salipa-Gurung
force-pushed
the
download-space
branch
from
d668d38 to
1a832fc
Compare
Salipa-Gurung
force-pushed
the
download-space
branch
from
1a832fc to
1a1eac9
Compare
Salipa-Gurung
changed the title
Salipa-Gurung
force-pushed
the
download-space
branch
5 times, most recently
from
bdb693d to
797a1cb
Compare
Salipa-Gurung
requested review from
SagarGi,
saw-jan,
amrita-shrestha,
SwikritiT,
grgprarup and
PrajwolAmatya
Salipa-Gurung
commented
Jul 11, 2023
grgprarup
reviewed
Jul 11, 2023
Salipa-Gurung
force-pushed
the
download-space
branch
4 times, most recently
from
603f4a0 to
1a9405f
Compare
saw-jan
reviewed
Jul 11, 2023
saw-jan
reviewed
Jul 11, 2023
saw-jan
reviewed
Jul 11, 2023
Salipa-Gurung
force-pushed
the
download-space
branch
from
1a9405f to
09826ff
Compare
SwikritiT
reviewed
Jul 13, 2023
Salipa-Gurung
force-pushed
the
download-space
branch
from
09826ff to
1505589
Compare
Salipa-Gurung
requested review from
SagarGi,
grgprarup and
amrita-shrestha
and removed request for
amrita-shrestha,
grgprarup and
SagarGi
Salipa-Gurung
force-pushed
the
download-space
branch
from
82aec8b to
3b31e9a
Compare
| So that I can store it in my local storage | ||
|
|
||
|
|
||
| Scenario: user downloads a space |
There was a problem hiding this comment.
@saw-jan what about adding test coverage for users tries to download space share with permission can edit and can manage? Will it be too much?
There was a problem hiding this comment.
should be easy with examples table
There was a problem hiding this comment.
But let's do it int next PR. This pr is almost a month old.
Scenarios to add:
- space member downloads space
- space-admin downloads other's space
Salipa-Gurung
force-pushed
the
download-space
branch
from
3b31e9a to
2d2c1b7
Compare
amrita-shrestha
force-pushed
the
download-space
branch
from
2d2c1b7 to
9146753
Compare
amrita-shrestha
force-pushed
the
download-space
branch
from
9146753 to
88fd279
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
9 tasks
ScharfViktor
approved these changes
Jul 20, 2023
|
TODO:
|
ownclouders
pushed a commit
that referenced
this pull request
Jul 20, 2023
* add test for downloading space * Add hidden file also --------- Co-authored-by: amrita <[email protected]>
ownclouders
pushed a commit
that referenced
this pull request
Jul 21, 2023
* add test for downloading space * Add hidden file also --------- Co-authored-by: amrita <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the API test scenario for downloading space.
Related Issue
ApiTest. next iteration
Motivation and Context
There was no test coverage for api test to download space and check the content of archive. So, this PR covers the required scenario test case.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: