Drone

owncloud · Jul 24, 2023 · 26cdad9 · 26cdad9
1 parent b94ceba
commit 26cdad9
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/.drone.star b/.drone.star
@@ -109,6 +109,7 @@ config = {
                 "apiSpacesShares",
                 "apiCors",
                 "apiAsyncUpload",
+                "apiDownloads",
             ],
             "skip": False,
         },

diff --git a/tests/acceptance/config/behat.yml b/tests/acceptance/config/behat.yml
@@ -55,7 +55,6 @@ default:
         - SpacesTUSContext:
         - GraphContext:
         - OcisConfigContext:
-        - ArchiverContext:
 
     apiSpacesShares:
       paths:
@@ -211,6 +210,26 @@ default:
         - OcisConfigContext:
         - PublicWebDavContext:
 
+    apiDownloads:
+      paths:
+        - '%paths.base%/../features/apiDownloads'
+      context: *common_ldap_suite_context
+      contexts:
+        - NotificationContext:
+        - SpacesContext:
+        - FeatureContext: *common_feature_context_params
+        - WebDavPropertiesContext:
+        - OCSContext:
+        - GraphContext:
+        - TrashbinContext:
+        - FavoritesContext:
+        - ChecksumContext:
+        - FilesVersionsContext:
+        - SettingsContext:
+        - OcisConfigContext:
+        - PublicWebDavContext:
+        - ArchiverContext:
+
   extensions:
     rdx\behatvars\BehatVariablesExtension: ~
 

diff --git a/...tance/features/apiSpaces/download.feature → ...ce/features/apiDownloads/download.feature b/...tance/features/apiSpaces/download.feature → ...ce/features/apiDownloads/download.feature
diff --git a/.../features/apiSpaces/spaceDownload.feature → ...atures/apiDownloads/spaceDownload.feature b/.../features/apiSpaces/spaceDownload.feature → ...atures/apiDownloads/spaceDownload.feature
@@ -46,7 +46,7 @@ Feature: Download space
       | viewer  |
 
 
-  Scenario Outline: admin and space admin tries to downloads other user space
+  Scenario Outline: admin and space admin try to download a space that they do not have access to
     Given the administrator has assigned the role "<userRole>" to user "Brian" using the Graph API
     When user "Brian" tries to download the space "Project-space" owned by user "Alice" using the WebDAV API
     Then the HTTP status code should be "404"

diff --git a/tests/acceptance/features/bootstrap/SpacesContext.php b/tests/acceptance/features/bootstrap/SpacesContext.php
@@ -3254,7 +3254,7 @@ public function theUserShouldHaveSpaceWithRecipient(
 	 * @throws GuzzleException
 	 */
 	public function userDownloadsTheSpaceUsingTheWebdavApi(string $user, string $spaceName, string $owner = ''):void {
-		$space = $this->getSpaceByName(($owner !== '') ? $owner : $user, $spaceName);
+		$space = $this->getSpaceByName($owner ?? $user, $spaceName);
 		$url = $this->featureContext->getBaseUrl() . '/archiver?id=' . $space['id'];
 		$this->featureContext->setResponse(
 			HttpRequestHelper::get(