Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to opencontainers annotation for docker images #1381

Merged
merged 6 commits into from
Feb 2, 2021
Merged

switch to opencontainers annotation for docker images #1381

merged 6 commits into from
Feb 2, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jan 21, 2021 •
edited
Loading

Description

Switch Docker image annotation scheme to org.opencontainers standard because org.label-schema is depreciated.

See: https://github.com/opencontainers/image-spec/blob/master/annotations.md
and: label-schema/label-schema.org@737d003

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the switch_to_opencontainer_annotation branch from 287e798 to 7685ed9 Compare January 21, 2021 21:24
@wkloucek wkloucek marked this pull request as ready for review January 22, 2021 07:24
@wkloucek wkloucek requested a review from xoxys January 22, 2021 07:25
@wkloucek
Copy link
Contributor Author

@xoxys do you have an idea how to create a RFC 3339 formatted timestamp in starlark / drone ci?

@xoxys
Copy link
Contributor

xoxys commented Jan 22, 2021

Hmm... not sure, after paying around with it, I can't get it to work

@wkloucek
Copy link
Contributor Author

Hmm... not sure, after paying around with it, I can't get it to work

I think then we need to leave it out and wait for drone to do it. You mentioned you have done it in your own plugin? Would that be something to contribute to upstream?

@wkloucek
Copy link
Contributor Author

PR in drone-docker which adds opencontainer labels: drone-plugins/drone-docker#313

@wkloucek wkloucek marked this pull request as draft January 22, 2021 12:35
@wkloucek wkloucek marked this pull request as ready for review February 2, 2021 10:04
@wkloucek
Copy link
Contributor Author

wkloucek commented Feb 2, 2021

@xoxys I removed the org.opencontainers.image.created label and for me it would be fine to merge

xoxys
xoxys approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xoxys
xoxys suggested changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkloucek wait there is a typo in the documentation url https://owncloud.github.io/ocis.git should be https://owncloud.github.io

@wkloucek
Copy link
Contributor Author

wkloucek commented Feb 2, 2021

@wkloucek wait there is a typo in the documentation url https://owncloud.github.io/ocis.git should be https://owncloud.github.io

is fixed

@wkloucek wkloucek requested a review from xoxys February 2, 2021 10:11
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 77533a9 into master Feb 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the switch_to_opencontainer_annotation branch February 2, 2021 13:54
@wkloucek wkloucek mentioned this pull request Feb 5, 2021
Merged
9 tasks
@micbar micbar mentioned this pull request Feb 17, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @xoxys