Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CI: push images to Dockerhub fails since PR 1381 #1600

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix CI: push images to Dockerhub fails since PR 1381 #1600

merged 1 commit into from
Feb 5, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 5, 2021

Description

#1381 introduced a bug that prevents pushing docker images to Dockerhub.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@owncloud owncloud deleted a comment from update-docs bot Feb 5, 2021
phil-davis
phil-davis approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkloucek wkloucek merged commit cabe57e into master Feb 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_ci_after_PR_1381 branch February 5, 2021 12:35
ownclouders pushed a commit that referenced this pull request Feb 5, 2021
@wkloucek
commit cabe57e
990a236 
Merge: d7215de 249e98b
Author: Willy Kloucek <[email protected]>
Date:   Fri Feb 5 13:35:20 2021 +0100

    Merge pull request #1600 from owncloud/fix_ci_after_PR_1381

    fix CI: push images to Dockerhub fails since PR 1381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar micbar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @phil-davis