-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for automatic opencontainer labels #313
Add support for automatic opencontainer labels #313
Conversation
lets simplify things by removing the deprecated labels entirely and only using the new labels going forward. I would then recommend we use a boolean flag to disable automatic labeling, perhaps |
a296e31
to
bd40298
Compare
All done @bradrydzewski |
You might want to restart CI, looks like it reached docker hub's api rate limit... |
|
||
if len(build.LabelSchema) > 0 { | ||
labelSchema = append(labelSchema, build.LabelSchema...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tboerger can you confirm that label_schema
values should be ignored if the user sets auto_label: false
? This operation is wrapped by if build.AutoLabel { ...
and I was wondering if it should be moved outside this block, or if this is fine as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an option to opt-out is fine, I know some people that really asked for that.
Friendly bump 😄 |
@bradrydzewski Could you please merge this one? |
Adding support for automatically setting
opencontainers
labels as default. Also, now there is a way to turn off automatic labeling.It's documented here:
Using
-e PLUGIN_AUTO_LABEL=false
:With
-e PLUGIN_AUTO_LABEL=true
,DRONE_REMOTE_URL
, andDRONE_REPO_LINK
: