Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Consistency in Identifier fields #32

Closed
4 tasks done
kulmann opened this issue Jun 8, 2020 · 1 comment
Closed
4 tasks done

Consistency in Identifier fields #32

kulmann opened this issue Jun 8, 2020 · 1 comment

Comments

@kulmann
Copy link
Member

kulmann commented Jun 8, 2020

At the moment the fields in the Identifier message type are:

  • extension
  • bundleKey
  • settingKey

As proposed here #28 we could decide to drop the Key suffix. This has effect on several repositories:

  • ocis-settings: change protobuf, handlers and manager. regenerate api client and change ui code referencing the new identifier
  • ocis-accounts: change registering settings bundles to new identifier
  • ocis-hello: change registering settings bundles to new identifier
  • owncloud-sdk: copy the regenerated api client from ocis-settings into the vendor dir and adapt code to new identifier
kulmann added a commit that referenced this issue Jul 7, 2020
As tracked in #32 we
want to have consistent naming for the identifier fields. This is better
now.
@kulmann kulmann mentioned this issue Jul 10, 2020
28 tasks
kulmann added a commit that referenced this issue Jul 20, 2020
As tracked in #32 we
want to have consistent naming for the identifier fields. This is better
now.
@kulmann
Copy link
Member Author

kulmann commented Aug 19, 2020

Solved in ocis-settings, ocis-accounts, ocis-hello, owncloud-sdk and phoenix

@kulmann kulmann closed this as completed Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants