This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Adapt request to settings service to new API endpoint params #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
- Coverage 78.94% 76.51% -2.44%
==========================================
Files 54 54
Lines 4113 4275 +162
==========================================
+ Hits 3247 3271 +24
- Misses 866 1004 +138
Continue to review full report at Codecov.
|
LukasHirt
approved these changes
Jul 21, 2020
kulmann
force-pushed
the
settings-api-params
branch
from
1365533 to
217f938
Compare
xoxys
pushed a commit
that referenced
this pull request
Aug 19, 2020
xoxys
pushed a commit
that referenced
this pull request
Aug 19, 2020
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this ocis-settings PR gets merged the api call for listing settings values will require a different param nesting (
identifierdoesn't exist anymore,account_uuidis on highest level now).Since the settings are not in production anywhere just yet, we can already merge this, so that a PR in phoenix can be prepared.
Also, there was a nasty bug when the settings service is not available:
error.response.statuswas not accessible and threw an error. Fixed this by checking first if a response exists at all.