Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings #3806

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Fix settings #3806

merged 4 commits into from
Aug 19, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 22, 2020

The data model in ocis-settings has changed. Because of that we need to align our usage of it.

  • requires owncloud-sdk release with this pull request first
    until that is merged, you can run yarn build:system in owncloud sdk on your local machine and then yarn link it in phoenix.

@update-docs
Copy link

update-docs bot commented Jul 22, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann marked this pull request as ready for review August 19, 2020 10:09
@kulmann kulmann requested review from LukasHirt, PVince81 and refs August 19, 2020 10:10
@kulmann kulmann self-assigned this Aug 19, 2020
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulmann kulmann merged commit f76c33b into master Aug 19, 2020
@pascalwengerter pascalwengerter deleted the fix-settings branch April 8, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants