Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Improve Then step in apiShareReshareToRoot suites #39981

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[tests-only][full-ci] Improve Then step in apiShareReshareToRoot suites #39981

merged 1 commit into from
Apr 21, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of the When steps.

Suites covered:

  • apiShareReshareToRoot2
  • apiShareReshareToRoot3

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this Apr 19, 2022
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 19, 2022
Closed
@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareReshareToRoot branch from d5c65d6 to 2ef28e4 Compare April 19, 2022 10:26
@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareReshareToRoot branch from 2ef28e4 to 21ce0ea Compare April 19, 2022 10:37
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 20, 2022 03:35
SwikritiT
SwikritiT reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 396e02c into master Apr 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the improveThenStepInApiShareReshareToRoot branch April 21, 2022 07:20
SagarGi
SagarGi reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@grgprarup grgprarup Awaiting requested review from grgprarup

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrita-shrestha @phil-davis @SwikritiT @SagarGi