Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Improve Then step in apiShareReshareToRoot suites #39981

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[tests-only][full-ci] Improve Then step in apiShareReshareToRoot suites #39981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/acceptance/features/apiShareReshareToRoot2/reShareChain.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ Feature: resharing can be done on a reshared resource
And user "Brian" has shared file "textfile0_shared.txt" with user "Carol"
And user "Carol" has shared file "textfile0_shared.txt" with user "David"
When user "Brian" deletes file "/textfile0_shared.txt" using the WebDAV API
Then the content of file "/textfile0_shared.txt" for user "Carol" should be "ownCloud test text file 0"
Then the HTTP status code should be "204"
And the content of file "/textfile0_shared.txt" for user "Carol" should be "ownCloud test text file 0"
And the content of file "/textfile0_shared.txt" for user "David" should be "ownCloud test text file 0"
1 change: 1 addition & 0 deletions tests/acceptance/features/apiShareReshareToRoot3/reShareUpdate.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ Feature: sharing
And user "Alice" has updated the last share of "Alice" with
| permissions | create,update,read |
When user "Brian" deletes the last share using the sharing API
Then the HTTP status code should be "200"
And the OCS status code should be "<ocs_status_code>"
And user "Carol" should not have any received shares
Examples:
Expand Down
3 changes: 3 additions & 0 deletions tests/acceptance/features/bootstrap/Sharing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ public function userCreatesAShareWithSettings(string $user, ?TableNode $body):vo
$user,
$body
);
$this->pushToLastStatusCodesArrays();
}

/**
Expand Down Expand Up @@ -931,6 +932,7 @@ public function updateLastShareWithSettings(string $user, ?TableNode $body, ?str
*/
public function userUpdatesTheLastShareWith(string $user, ?TableNode $body):void {
$this->updateLastShareWithSettings($user, $body);
$this->pushToLastStatusCodesArrays();
}

/**
Expand Down Expand Up @@ -1876,6 +1878,7 @@ public function deleteLastShareUsingSharingApiByCurrentUser():void {
*/
public function userDeletesLastShareUsingTheSharingApi(string $user):void {
$this->deleteLastShareUsingSharingApi($user);
$this->pushToLastStatusCodesArrays();
}

/**
Expand Down