-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Drop php 7.0 bump phpunit7 20190731 #35962
Conversation
… merged and released
Since the DBAL update, the schema wrapper is not needed any more.
Unit tests to verify implementation of mb4 detection without touching the database.
…trine/dbal since 2.6.4
…P 7.0" This reverts commit 2a7d8ea.
5c5c5f1
to
f5d3953
Compare
Codecov Report
@@ Coverage Diff @@
## master #35962 +/- ##
============================================
- Coverage 65.4% 65.03% -0.37%
+ Complexity 20197 19430 -767
============================================
Files 1299 1296 -3
Lines 76762 76377 -385
Branches 1301 1301
============================================
- Hits 50203 49675 -528
- Misses 26174 26317 +143
Partials 385 385
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35962 +/- ##
============================================
- Coverage 65.4% 65.03% -0.37%
+ Complexity 20197 19430 -767
============================================
Files 1299 1296 -3
Lines 76762 76377 -385
Branches 1301 1301
============================================
- Hits 50203 49675 -528
- Misses 26174 26317 +143
Partials 385 385
Continue to review full report at Codecov.
|
ToDo: rebase this and sort out the drone.yml changes |
See PR #36290 for a rebased-updated version that works with the new drone starlark CI code. |
Description
Combination of
#35786 "drop PHP 7.0"
#34921 Bump phpunit7 (backport)
Extra commit: "Update method signatures for EncryptionTrait markTestSkipped and assertTrue" to fix a problem reported in the encryption unit test code (which is not in
master
), to fix:Related Issue
Motivation and Context
See if it passes all together.
How Has This Been Tested?
CI
Types of changes
Checklist: