-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] drop php 7.0 and add phpunit7 [DO NOT MERGE YET] #35804
[stable10] drop php 7.0 and add phpunit7 [DO NOT MERGE YET] #35804
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #35804 +/- ##
==============================================
- Coverage 65.09% 64.73% -0.37%
+ Complexity 20239 19471 -768
==============================================
Files 1300 1297 -3
Lines 77238 76869 -369
Branches 1301 1301
==============================================
- Hits 50279 49760 -519
- Misses 26574 26724 +150
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35804 +/- ##
==============================================
- Coverage 65.1% 64.71% -0.39%
+ Complexity 20197 19412 -785
==============================================
Files 1302 1298 -4
Lines 77158 76725 -433
Branches 1301 1301
==============================================
- Hits 50232 49655 -577
- Misses 26541 26685 +144
Partials 385 385
Continue to review full report at Codecov.
|
@DeepDiver1975 this works on top of "drop PHP 7.0" PR #35786 I suggest just give "comment" reviews. Do not click "Approve" yet. That will prevent any accidental merge of this PR. |
3d7b7de
to
8d712fa
Compare
Since the DBAL update, the schema wrapper is not needed any more.
Unit tests to verify implementation of mb4 detection without touching the database.
… merged and released
…trine/dbal since 2.6.4
8d712fa
to
0827e08
Compare
See PR #35962 for the updated version of this after the |
Description
Combination of
#35786 "drop PHP 7.0"
#34921 Bump phpunit7 (backport)
Extra commit: "Update method signatures for EncryptionTrait markTestSkipped and assertTrue" to fix a problem reported in the encryption unit test code (which is not in
master
), to fix:Related Issue
Motivation and Context
See if it passes all together.
How Has This Been Tested?
CI
Types of changes
Checklist: