-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For 10.4] Drop php 7.0 bump phpunit7 #36290
Conversation
This is a rebased-refactor of PR #35962 that works with the new @DeepDiver1975 @PVince81 @micbar and others please review to see what is good/needs fixing or has been forgotten. Just make review comments - probably best not to click "approve" just yet (or someone might merge it) Then it will be here ready for whenever the decision is made to release "drop PHP 7.0" |
Codecov Report
@@ Coverage Diff @@
## master #36290 +/- ##
============================================
- Coverage 65.18% 64.68% -0.51%
+ Complexity 19794 19023 -771
============================================
Files 1271 1268 -3
Lines 74730 74362 -368
Branches 1309 1309
============================================
- Hits 48712 48100 -612
- Misses 25632 25876 +244
Partials 386 386
Continue to review full report at Codecov.
|
14cd6fb
to
1e0b2a9
Compare
1570d6a
to
8a950cf
Compare
5328ef0
to
d4f73fc
Compare
0bb83f2
to
b148bd4
Compare
b148bd4
to
daf1de4
Compare
@PVince81 @DeepDiver1975 @micbar this is ready for review. We could merge this whole PR that also includes |
Description
This PR is a place to put things that are waiting to go into
stable10
but that require PHP7.1+ and so cannot be merged until PHP7.0 support can be dropped. (from PR #36289 )Plus moving from
phpunit6
tophpunit7
phpunit-mock-objects
change never got into a release with dependencies for phpunit6)stable10
which is nowadaysmaster
)doctrine/dbal
version bump that comes when composer PHP 7.1 happens)put back some test code that was for PHP 7.1-only (ref PR: Revert void return type declarations that are not valid in PHP 7.0 #35958 )
add commits to update
phpunit
to V7.5.17Related Issue
#29483 MariaDB
#33187 PostgreSQL 10
Motivation and Context
Gather all the changes required for "drop PHP7.0" and related support for newer MariaDB and PostgreSQL versions... that were in the "old" master, and have them ready for "new" master.