don't delete the source files when generating thumbnails

[DeepDiver1975]

Description

Thumbnail providers shall not delete the source files.

Related Issue

fixes #31655

How Has This Been Tested?

• local unit test execution with necessary tools installed: libreoffice + jre + ffmpeg + php-imagick

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #31659 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #31659      +/-   ##
============================================
- Coverage     62.87%   62.87%   -0.01%     
  Complexity    18409    18409              
============================================
  Files          1151     1151              
  Lines         69114    69112       -2     
  Branches       1260     1260              
============================================
- Hits          43458    43454       -4     
- Misses        25287    25289       +2     
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	52.39% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.08% <0%> (-0.01%)	18409 <0> (ø)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Preview/MP3.php	45.16% <ø> (-11.09%)	13 <0> (ø)
lib/private/Preview/Office.php	0% <0%> (ø)	14 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f2d39...ebf6940. Read the comment docs.

[sharidas]

LGTM 👍

[DeepDiver1975]

cherry-picked the commit to #31050

[phil-davis]

So that means this has effectively been backported. But the fix will not get into a release until those "[stable10] Backport all objectstore related changes" #31050 are merged to stable10

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.