Preview generation destroys MP3 files!

[paulijar]

On ownCloud master branch (10.1.0 prealpha), opening a folder containing MP3 files will permanently delete all those files from the filesystem. The files remain visible in ownCloud but they are lost from the disk, as can be noticed when you try to download one of the files.

The culprit commit seems to be 95e0e0c and the bug is on this line: https://github.com/owncloud/core/blob/master/lib/private/Preview/MP3.php#L57. There, $absPath may point either to a temporary copy or the original file, but the file is deleted regardless!

[ownclouders]

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #7593 (No download share link and previews file), #14106 (previews broken for non-supported file types), #5176 (Preview for avi files), #8010 (Sharing: Text file preview), and #6587 (disable file preview for specific files).

[patrickjahns]

@paulijar
could you try stable10 with #31050 and see if on that PR you encounter the same behavior?

[DeepDiver1975]

could you try stable10 with #31050 and see if on that PR you encounter the same behavior?

the code is the same in the backport - will fix asap and add to #31050

[DeepDiver1975]

fix is ready to be tested ^ @paulijar

[patrickjahns]

the code is the same in the backport - will fix asap and add to #31050

hence asking to test on stable10 with this PR - if there are other changes involved that might have caused the regression to occur

thx for the fix

[DeepDiver1975]

master pr is merged - commit is cherry-picked to #31050 @patrickjahns FYI

[paulijar]

I pulled the core master branch and it seems to work fine now.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.