Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail not regenerated as file changes #31849

Closed
phil-davis opened this issue Jun 21, 2018 · 10 comments · Fixed by #31853
Closed

Thumbnail not regenerated as file changes #31849

phil-davis opened this issue Jun 21, 2018 · 10 comments · Fixed by #31853

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Jun 21, 2018

Steps part 1

  1. Login as "someuser"
  2. Create a file "test.txt" and edit several times to create versions
  3. Open the "Versions" tab in the sidebar
  4. Restore some previous version
  5. Close the "Versions" panel, even refresh the whole files page
  6. Look at the thumbnail preview

Expected results

Thumbnail shows content from the restored version.

Actual result

Thumbnail shows unchanged content.

Version

10.0.9RC1

Steps part 2

There is no thumbnail update when doing upload-overwrite:

  1. Upload some x.png file - observe the thumbnail looks like a small version of the file content
  2. Locally edit/replace the x.png file with some other graphics content
  3. Upload x.png and choose to keep the new file
  4. Download x.png - check that is does have the new content

Expected results

Thumbnail displays updated content

Actual result

Thumbnail shows unchanged content.

Steps part 3

There is no thumbnail update when editing an existing text file:

  1. Create a new text file with some content - observe that the thumbnail shows the early content
  2. Edit the text file in the webUI, changing some content early on line 1 (to make sure it should be part of the thumbnail)

Expected results

Thumbnail displays updated content

Actual result

Thumbnail shows unchanged content.

@phil-davis
Copy link
Contributor Author

Issue #31797 fixed up thumbnails being displayed for each version in PR #31801 - perhaps there is something more to do in an area close to that to get thumbnail regeneration going again?

Issue #10559 had this problem some years ago, and was closed/fixed.

@phil-davis
Copy link
Contributor Author

Works in 10.0.8

@phil-davis
Copy link
Contributor Author

@davitol please try to reproduce this, to make sure I am not imagining.

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #19219 (Thumbnail is not updated, when restoring a file), #10559 (Thumbnails not regenerated when reverting to an earlier version of a file), #28115 (Thumbnails are not shown in the version section), #205 (Files: thumbnails), and #31659 (don't delete the source files when generating thumbnails).

@davitol
Copy link
Contributor

davitol commented Jun 21, 2018

versionthumb
It seems it works for me. Are you using regular storage or an external one?

@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 21, 2018

In your screen capture, the thumbnail of the file keeps showing "asdfa" - but it should change as you restore different versions.

@davitol
Copy link
Contributor

davitol commented Jun 21, 2018

In your screen capture, the thumbnail of the file keeps showing "asdfa" - but it should change as you restore different versions.

Yes I misunderstood the title. It happens for me justonly editing the file, no need of restoring a version

@phil-davis
Copy link
Contributor Author

As discussed in chat, thumbnail update is working while editing a new file. But if I edit an existing file, then the content changes OK, but the thumbnail is not updated.

@phil-davis phil-davis changed the title Thumbnail not regenerated when old version of file is restored Thumbnail not regenerated as file changes Jun 21, 2018
@PVince81
Copy link
Contributor

@DeepDiver1975 are you able to have a look ? are we missing some hook triggers to tell the preview system to reset the preview after restore ?

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants