Share dialog use OCS API

[PVince81]

Preliminary work.

• create share
• update share (permissions)
• delete share
• enable/disable link share
• send mail checkbox
• update link share (kind of clumsy currently due to mismatch property names...)
  • password
  • expiration date ("expireDate" vs "expiration" 😵)
  • public upload
  • mail flag => skipped: no OCS API for now ⚠️
• mailsend => skipped: no OCS API for now ⚠️
• reshares
• remote shares => API broken ?!
• "collection" mode for some shares, possibly containing the parent share => obsolete with new resharing behavior
• status indicator in file list
• retest: enforce password
• retest: enforce default date

If possible:

• get rid of OC.Share.loadItem if po => to be done separately due to API complications
• get rid of legacy structures (OC.Share.currentShares) => to be done separately due to API complications

I'm not 100% on using backbone here because the API is not REST-y enough.
We'll see.

@rullzer FYI

[mention-bot]

By analyzing the blame information on this pull request, we identified @blizzz, @DeepDiver1975 and @MTGap to be potential reviewers

[PVince81]

Ref: #21554

[PVince81]

I removed the backbone bits for now and used direct ajax calls.

[PVince81]

• TODO: only fetch owner/reshare info once in model.fetch, no need to refetch it as it won't change

[PVince81]

• TODO: try and reduce the number of re-fetches in situations where it's not needed (ex: deleting or changing permissions)

[PVince81]

• BUG: cannot change permissions of a reshare, getting 404

@rullzer bug ?

[PVince81]

Okay, I fixed many things including the unit tests, plus a few bonus unit tests.

It's already a nice stable ground.
However due to possible backend bugs this cannot be merged yet.
Let's wait for @rullzer's other OCS API PRs to be merged first.

Also I'd like to try to get rid of the legacy share structure completely, the "OC.Share.loadItem" and "OC.Share.statuses" which is still used by the files app to show share status.

[PVince81]

• replace OC.Share.loadIcons with a call with subfiles=true: curl -X GET 'http://root:admin@localhost/owncloud/ocs/v2.php/apps/files_sharing/api/v1/shares?path=abc&subfiles=true&format=json'
  Note that this is limited to a single level, so need to do this call every time when switching folders, which is fine and will fix Files or folders are not shown as shared unless the page is refreshed #6813 => to be done separately due to API complications

[PVince81]

on the other hand that calls seems wasteful.
If a folder "/abc/test" is shared with 100 users, and the user visits "abc", then we'd receive 100 share entries, just to be able to show the "Shared" icon. Ideal would be to be able to get a summary.

[PVince81]

Changing reshare permissions as recieiver now works.

• BUG: Share with link doesn't work any more: the backend doesn't allow "expireDate" to be an empty string at creation time.

and as previously said, remote shares still cannot be created.

[PVince81]

Rebased on master

[PVince81]

@rullzer with #21960 it works better.

However it doesn't let me "PUT permissions" on a share link to set "Allow upload". It used to work.
I don't want to use "publicUpload"...

[rullzer]

Aaah. OK I will fix that as well :-)

[PVince81]

• TODO: use urlencoded form instead of JSON for requests, which is supposed to work properly for all calls and will fix the remote share one

[PVince81]

• REQUIRES: Share2 ocs fix passing empty strings #21960

[MorrisJobke]

Tested and works 👍 (tested together with #21960)

[MorrisJobke]

@PVince81 JS unit tests:

05:04:04 PhantomJS 1.9.8 (Linux 0.0.0) OC.Share.ShareItemModel saveLinkShare creates a new share with default expiration date FAILED
05:04:04    Expected Object({ password: '', passwordChanged: false, permissions: 1, expireDate: '2015-7-23 00:00:00', shareType: 3 }) to equal Object({ password: '', passwordChanged: false, permissions: 1, expireDate: '2015-7-24 00:00:00', shareType: 3 }).
05:04:04        at /ssd/jenkins/workspace/core-ci-linux-jsunit/database/sqlite/label/SLAVE/core/js/tests/specs/shareitemmodelSpec.js:638

[PVince81]

Weird, I'm not getting this error locally. Maybe a timezone thing

[PVince81]

It was a timezone issue.
I've replaced the default expiration date calculation by using momentjs for more accurate UTC calculation: c9f4012

[MorrisJobke]

@PVince81 Please check out the failing unit tests

[PVince81]

JS Unit pass now. Let's wait for #21975 to be merged

[rullzer]

Failing unit tests cased by the merging of the two share pr's... that had some conflicting code... fix is in #21975

[PVince81]

Rebased

[rullzer]

• I don't get feedback from the password_policy app if setting the password generates an error

[rullzer]

Awesome work @PVince81!
Clicked around a lot and beside the password policy app everything worked fine.

I'm fine with fixing the passwordpolicy feedback in a different PR>

👍

[PVince81]

I'll have a look at that issue separately.

[PVince81]

Raised here #21992