Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web interface should use the OCS Share API #21554

Closed
rullzer opened this issue Jan 8, 2016 · 6 comments
Closed

Web interface should use the OCS Share API #21554

rullzer opened this issue Jan 8, 2016 · 6 comments
Assignees
Milestone

Comments

@rullzer
Copy link
Contributor

rullzer commented Jan 8, 2016

In order to allow core to move away from the old sharing code we need to migrate the webinterface to the OCS Share API. (see #19331).

This requires fixing the backbone model to do json calls to the OCS endpoint instead of the current ajax endpoints.

@PVince81 as discussed.

@rullzer rullzer added this to the 9.0-current milestone Jan 8, 2016
@rullzer rullzer mentioned this issue Jan 8, 2016
43 tasks
@PVince81
Copy link
Contributor

PVince81 commented Jan 8, 2016

Two parts:

  • Adjust core/js/share.js, the part that retrieves share info for the file list icon/states
  • Adjust share dialog

@PVince81
Copy link
Contributor

PR in progress here: #21860

@PVince81
Copy link
Contributor

PVince81 commented Feb 5, 2016

We still have core/share.js requiring a summarizing call:

There is a similar core in OCS but the response is huge and wasteful and might cause performance impact when many shares. See #21798 (comment)

@PVince81
Copy link
Contributor

PVince81 commented Feb 5, 2016

Discussed with @DeepDiver1975, one idea would be to return the summarized share info as part of the Webdav response. Add a new property "oc:share" or "oc:shareTypes" or "oc:shareIds" that makes it possible to display the icon (regular share or public share) in the web UI.

The fetching of the shares of a folder must use a method on the share manager to retrieve all shares by folder, passing the file id. Fetching shares individually for every file id would be unefficient.

@PVince81
Copy link
Contributor

Now using OCS response for status icons: #22305

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants