-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate the share statuses in js from the OCS Response #22305
Conversation
OC.Share.statuses[share.item_source] = {link: false}; | ||
} | ||
if (share.share_type === OC.Share.SHARE_TYPE_LINK) { | ||
OC.Share.statuses[share.item_source] = {link: true}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that all ? I thought there were more statuses returned also for non-link shares ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that is all... at least what the old endpoint returned... in the future we might expand this to more info... since we can show who we shared with in the list now...
Right now this is only done on page load. We should do it on each directory traversal.
31b8b43
to
a823485
Compare
Ok reloads working. Please review: @PVince81 @nickvergessen @schiesbn |
Tested, works 👍 |
In 9.1 we can look into either making this a proper compact summary call, or to actually use the info returned by the share API to display the recipients in the indicator (to do so, set "data-recipients" on the row) |
Tested and works 👍 |
Calculate the share statuses in js from the OCS Response
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #22298
Right now this is only done on page load. We should do it on each directory traversal.
@PVince81 can you help out?