Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate the share statuses in js from the OCS Response #22305

Merged
merged 2 commits into from
Feb 12, 2016

Conversation

rullzer
Copy link
Contributor

@rullzer rullzer commented Feb 11, 2016

Fixes #22298

Right now this is only done on page load. We should do it on each directory traversal.

@PVince81 can you help out?

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @Kondou-ger, @PVince81 and @blizzz to be potential reviewers

OC.Share.statuses[share.item_source] = {link: false};
}
if (share.share_type === OC.Share.SHARE_TYPE_LINK) {
OC.Share.statuses[share.item_source] = {link: true};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that all ? I thought there were more statuses returned also for non-link shares ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is all... at least what the old endpoint returned... in the future we might expand this to more info... since we can show who we shared with in the list now...

Right now this is only done on page load. We should do it on each
directory traversal.
@rullzer
Copy link
Contributor Author

rullzer commented Feb 11, 2016

Ok reloads working.

Please review: @PVince81 @nickvergessen @schiesbn

@PVince81
Copy link
Contributor

Tested, works 👍

@PVince81
Copy link
Contributor

In 9.1 we can look into either making this a proper compact summary call, or to actually use the info returned by the share API to display the recipients in the indicator (to do so, set "data-recipients" on the row)

@MorrisJobke
Copy link
Contributor

Tested and works 👍

DeepDiver1975 added a commit that referenced this pull request Feb 12, 2016
Calculate the share statuses in js from the OCS Response
@DeepDiver1975 DeepDiver1975 merged commit cb1051d into master Feb 12, 2016
@DeepDiver1975 DeepDiver1975 deleted the sharestatus_to_ocs_22298 branch February 12, 2016 10:12
@lock
Copy link

lock bot commented Aug 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect share identifier for reshares
5 participants