Fix OCS unit tests after two share merges #21975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use getNode * Return IShare object so typechecking is happy
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975 to be a potential reviewer |
| $this->callback(function (IShare $share) use ($path, $currentUser) { | ||
| return $share->getPath() === $path && | ||
| $this->callback(function (\OCP\Share\IShare $share) use ($path, $currentUser) { | ||
| return $share->getNode() === $path && |
There was a problem hiding this comment.
$path = $this->getMock('\OCP\Files\Folder');
|
Fixes the tests 👍 |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Jan 28, 2016
Fix OCS unit tests after two share merges
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging of #21957 and #21960 created some conflicts.
Should all be fixed now!
CC: @PVince81 @MorrisJobke @DeepDiver1975 @nickvergessen @schiesbn @LukasReschke